Fix Fraction.add and subtract for operands not in lowest terms - #1784
Open
lenamonj wants to merge 1 commit into
Open
Fix Fraction.add and subtract for operands not in lowest terms#1784lenamonj wants to merge 1 commit into
lenamonj wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fraction.addSubruns Knuth 4.5.1 on the operands as given, but the algorithm assumes lowest terms andgetFraction(50, 100)is stored as 50/100. A shared factor inside an operand survives into the common denominator, soaddandsubtractthrowArithmeticExceptionwhile the exact result fits an int (1073741823/2147483646 plus 3/5 is 11/10) and return unreduced results against the reduced form the javadoc promises. #1769 fixed the same shape inmultiplyBy.Both operands are now reduced before the Knuth step, as
multiplyBydoes. Operands already in lowest terms take the identical path, so the existing overflow and identity assertions hold.Test:
testAddSubtractUnreducedOperands, red on master and green with the change. Default Maven goal green.mvn; that'smvnon the command line by itself.