fix: normalize noncanonical NaN literals in comparisons - #5472
Draft
sunchao wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue is automatically closed. This is a standalone scalar-comparison normalization fix.
Rationale for this change
Comet normalizes floating-point comparison operands to match Spark's NaN and signed-zero semantics, but the literal fast path skips every float/double literal except negative zero. That also skips NaNs with a different sign or payload. Such literals can therefore retain a different ordering/equality representation from a normalized input column.
What changes are included in this PR?
!isNaNto the two literal fast-path guards so NaN literals use the existing normalization path.The production change is only the two guards. No normalization refactor, join changes, configuration changes, or new dependency is included. The tests use the default floating-point mode.
How are these changes tested?
Draft: JVM validation is blocked, so no passing JVM test result is claimed.
5baa6b03.git diff --checkpassed.Red/green confirmation of the two new regressions and the existing signed-zero/NaN checks remains required before this draft is ready to merge.