Visit CreateView name as a relation - #2442
Open
sabir-akhadov-localstack wants to merge 1 commit into
Open
Conversation
The visitor framework skipped CreateView.name, so visit_relations / visit_relations_mut did not surface or rewrite the view name in CREATE VIEW statements, unlike CreateTable, CreateIndex, and AlterTable which already annotate their names with visit_relation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sabir-akhadov-localstack
marked this pull request as ready for review
August 18, 2026 09:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
visit_relations/visit_relations_mutdid not visit the view name inCREATE VIEWstatements:CreateTable,CreateIndex,Msck, andAlterTablealready annotate their object names withvisit(with = "visit_relation")—CreateView.namewas missing the annotation. This PR adds it, so tools that inspect or rewrite relation references (e.g. schema rewriters) see the view name too.