Repository navigation
SQLite: Reject colon-based semi-structured data traversal - #2613
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
a0425ba to
e30f8ff
Compare
sabir-akhadov-localstack
left a comment
There was a problem hiding this comment.
Conflicts with main: #2683 added get_next_precedence to this impl (&/| arm) and parse_unterminated_block_comment lands at the same spot in the test file; needs a rebase.
| None | ||
| } | ||
|
|
||
| fn get_next_precedence(&self, parser: &Parser) -> Option<Result<u8, ParserError>> { |
Please do not add review notes on rebases, those are pretty evident by themselves. |
9aa2315 to
add1eeb
Compare
add1eeb to
306917e
Compare
|
Thanks @s5dsn-eqee and @sabir-akhadov-localstack for your reviews, I will be merging this now. cc @alamb |
SQLiteDialectparsesSELECT c:seas aJsonAccessexpression, the same:semi-structured traversal Snowflake and Databricks use. Real SQLite rejects it:near ":se": syntax error.SQLiteDialectnow overridesget_next_precedenceforToken::Colon, the same pattern PostgreSqlDialect and MsSqlDialect already use, so:never starts an infix parse there. Named parameters,::casts, and->/->>are unaffected.