Repository navigation
ClickHouse: Accept an unterminated dollar-quote tag as an identifier - #2894
Queued
s5dsn-eqee wants to merge 4 commits into
Queued
s5dsn-eqee wants to merge 4 commits into
s5dsn-eqee wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2894 +/- ##
=======================================
Coverage 83.20% 83.21%
=======================================
Files 42 42
Lines 36471 36487 +16
Branches 36471 36487 +16
=======================================
+ Hits 30345 30361 +16
Misses 2632 2632
Partials 3494 3494 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
requested changes
Nov 9, 2026
…se docs, add tag matching and span tests
LucaCappelletti94
approved these changes
Nov 11, 2026
Contributor
|
Will be merging this one now, thanks @s5dsn-eqee cc @alamb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found with #2646.
SELECT $a$ xfailed withUnterminated dollar-quoted, expected $. ClickHouse reads$a$as a heredoc only when a matching closing$a$follows; otherwise the tag is a bare word (Lexer.cpp, "start of heredoc"). Not in the syntaxdocs.
Dialects: ClickHouse