Skip to content

ClickHouse: Accept an unterminated dollar-quote tag as an identifier - #2894

Queued
s5dsn-eqee wants to merge 4 commits into
apache:mainfrom
s5dsn-eqee:clickhouse-unterminated-dollar-tag
Queued

s5dsn-eqee wants to merge 4 commits into
apache:mainfrom
s5dsn-eqee:clickhouse-unterminated-dollar-tag

Conversation

@s5dsn-eqee

Copy link
Copy Markdown
Contributor

Found with #2646.

SELECT $a$ x failed with Unterminated dollar-quoted, expected $. ClickHouse reads $a$ as a heredoc only when a matching closing $a$ follows; otherwise the tag is a bare word (Lexer.cpp, "start of heredoc"). Not in the syntax
docs.

Dialects: ClickHouse

@codecov-commenter

codecov-commenter commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.21%. Comparing base (8a176d9) to head (f4af460).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2894   +/-   ##
=======================================
  Coverage   83.20%   83.21%           
=======================================
  Files          42       42           
  Lines       36471    36487   +16     
  Branches    36471    36487   +16     
=======================================
+ Hits        30345    30361   +16     
  Misses       2632     2632           
  Partials     3494     3494           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/tokenizer.rs Resolved
@LucaCappelletti94

Copy link
Copy Markdown
Contributor

Will be merging this one now, thanks @s5dsn-eqee

cc @alamb

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants