Repository navigation
PostgreSQL: Parse NCHAR as a character string type - #2906
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## upstream/national-char-varying #2906 +/- ##
=================================================================
Coverage ? 83.22%
=================================================================
Files ? 42
Lines ? 36503
Branches ? 36503
=================================================================
Hits ? 30378
Misses ? 2632
Partials ? 3493 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NCHAR(4)parses only because unknown type names fall through toDataType::Custom, so it reaches consumers as an opaque name with a string modifier instead of a character string type with a length.parse_data_typenow reads it intoDataType::Nchar, which prints back as written, the same wayCHARACTER VARYINGandCHAR VARYINGare kept apart.