Skip to content

PostgreSQL: Support NCHAR VARYING - #2908

Open
LucaCappelletti94 wants to merge 1 commit into
upstream/ncharfrom
upstream/nchar-varying
Open

LucaCappelletti94 wants to merge 1 commit into
upstream/ncharfrom
upstream/nchar-varying

Conversation

@LucaCappelletti94

@LucaCappelletti94 LucaCappelletti94 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

CREATE TABLE t (c NCHAR VARYING(4)) does not parse, in a column definition or in a cast.

parse_data_type now reads it into DataType::NcharVarying, which prints back as written, the same way CHARACTER VARYING and CHAR VARYING are kept apart.

This is the last one of the stack!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.22%. Comparing base (422fd78) to head (bac9926).

Additional details and impacted files
@@               Coverage Diff               @@
##           upstream/nchar    #2908   +/-   ##
===============================================
  Coverage           83.22%   83.22%           
===============================================
  Files                  42       42           
  Lines               36503    36505    +2     
  Branches            36503    36505    +2     
===============================================
+ Hits                30378    30380    +2     
  Misses               2632     2632           
  Partials             3493     3493           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94 LucaCappelletti94 added enhancement New feature or request api change labels Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants