Skip to content

ci: Check datafusion-spark feature combinations to catch publish errors - #24475

Draft
alamb wants to merge 3 commits into
apache:mainfrom
alamb:alamb/spark_feature_check
Draft

ci: Check datafusion-spark feature combinations to catch publish errors#24475
alamb wants to merge 3 commits into
apache:mainfrom
alamb:alamb/spark_feature_check

Conversation

@alamb

@alamb alamb commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Publishing datafusion-spark 55.0.0 failed with

error[E0433]: cannot find module or crate `datafusion` in this scope
  --> src/function/string/quote.rs:20:5

because the library referenced the optional datafusion dependency (only enabled by the core feature) from code that is not gated on that feature.

CI did not catch this workspace-wide builds always compile datafusion-spark with the optional datafusion dependency present due to feature unification.

The underlying import error was already fixed on main in #24351, so this PR adds the missing CI coverage to prevent the problem from reoccurring.

What changes are included in this PR?

Add a cargo check datafusion-spark features CI job, following the pattern of the existing per-crate feature check jobs (e.g. datafusion-functions), that checks the crate standalone.

Also add the new job to the required status checks in .asf.yaml, like the other per-crate feature check jobs.

Are these changes tested?

Yes, by CI itself (the new job runs on this PR).

Are there any user-facing changes?

No, CI only.

@github-actions github-actions Bot added the development-process Related to development process of DataFusion label Aug 18, 2026
- name: Check datafusion-functions (unicode_expressions)
run: cargo check --profile ci --no-default-features -p datafusion-functions --features=unicode_expressions

# Check datafusion-spark crate features

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strange to see an entirely new job for this, but it mirrors what the other check jobs do 🤷

Maybe we can consolidate some of the check jobs to reduce CI cost

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.22%. Comparing base (f6ad781) to head (62ee1ee).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #24475    +/-   ##
========================================
  Coverage   81.22%   81.22%            
========================================
  Files        1113     1113            
  Lines      392250   392508   +258     
  Branches   392250   392508   +258     
========================================
+ Hits       318591   318832   +241     
- Misses      54914    54916     +2     
- Partials    18745    18760    +15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error publishing datafusion-spark in datafusion 55.0.0 release "cannot find module or crate datafusion in this scope"

2 participants