ci: Check datafusion-spark feature combinations to catch publish errors - #24475
Draft
alamb wants to merge 3 commits into
Draft
ci: Check datafusion-spark feature combinations to catch publish errors#24475alamb wants to merge 3 commits into
alamb wants to merge 3 commits into
Conversation
alamb
commented
Aug 18, 2026
| - name: Check datafusion-functions (unicode_expressions) | ||
| run: cargo check --profile ci --no-default-features -p datafusion-functions --features=unicode_expressions | ||
|
|
||
| # Check datafusion-spark crate features |
Contributor
Author
There was a problem hiding this comment.
It is strange to see an entirely new job for this, but it mirrors what the other check jobs do 🤷
Maybe we can consolidate some of the check jobs to reduce CI cost
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24475 +/- ##
========================================
Coverage 81.22% 81.22%
========================================
Files 1113 1113
Lines 392250 392508 +258
Branches 392250 392508 +258
========================================
+ Hits 318591 318832 +241
- Misses 54914 54916 +2
- Partials 18745 18760 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusionin this scope" #24474Rationale for this change
Publishing
datafusion-spark55.0.0 failed withbecause the library referenced the optional
datafusiondependency (only enabled by thecorefeature) from code that is not gated on that feature.CI did not catch this workspace-wide builds always compile
datafusion-sparkwith the optionaldatafusiondependency present due to feature unification.The underlying import error was already fixed on
mainin #24351, so this PR adds the missing CI coverage to prevent the problem from reoccurring.What changes are included in this PR?
Add a
cargo check datafusion-spark featuresCI job, following the pattern of the existing per-crate feature check jobs (e.g.datafusion-functions), that checks the crate standalone.Also add the new job to the required status checks in
.asf.yaml, like the other per-crate feature check jobs.Are these changes tested?
Yes, by CI itself (the new job runs on this PR).
Are there any user-facing changes?
No, CI only.