Fix topk emitted batches - #24481
Open
cetra3 wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24481 +/- ##
==========================================
- Coverage 81.24% 81.24% -0.01%
==========================================
Files 1113 1113
Lines 392744 392816 +72
Branches 392744 392816 +72
==========================================
+ Hits 319090 319145 +55
- Misses 54900 54909 +9
- Partials 18754 18762 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
output_batchesmetric does not match the number of emitted batches #24468metrics()returnsNone) #24470Rationale for this change
Fixes some issues around metrics and TopK execution nodes
What changes are included in this PR?
Adjusts to include metrics in PartitionedTopKExec and also fixes the batch count in TopK
Are these changes tested?
Yes new tests added.
Are there any user-facing changes?
No new traits, etc.. just fixes some bugs on the physical plan side