Repository navigation
docs: Add example and cross-links to GroupingEquivalenceClass - #27237
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
alamb
marked this pull request as ready for review
November 8, 2026 14:10
This was referenced Nov 8, 2026
NGA-TRAN
approved these changes
Nov 9, 2026
NGA-TRAN
left a comment
NGA-TRAN
left a comment
Contributor
There was a problem hiding this comment.
Nice description of the feature. Thanks Andrew
nuno-faria
approved these changes
Nov 9, 2026
Comment on lines
+28
to
+43
| /// ┌───┬───┬───┐ | ||
| /// │ a │ b │ c │ | ||
| /// ├───┼───┼───┤ | ||
| /// │ 2 │ 1 │ 5 │ | ||
| /// │ 2 │ 1 │ 3 │ | ||
| /// │ 1 │ 3 │ 4 │ | ||
| /// │ 2 │ 2 │ 1 │ | ||
| /// │ 2 │ 2 │ 2 │ | ||
| /// └───┴───┴───┘ | ||
| /// ``` | ||
| /// | ||
| /// * Is grouped by `[a, b]`, as rows with the same `(a, b)` are contiguous, | ||
| /// even though the table is not sorted by `a`, `b` nor `(a, b)`. | ||
| /// * Is grouped by `[b]`, since each value of `b` is in one run. | ||
| /// * Is NOT grouped by `[a]`, because `a = 2` appears in two separate runs. | ||
| /// |
Contributor
There was a problem hiding this comment.
Is it also grouped by c, c,a, ...? 🤔
Contributor
Author
There was a problem hiding this comment.
I think so for this example because c is distinct.
Contributor
Author
There was a problem hiding this comment.
I added a new bullet
Is grouped by
[c], and by any tuple that containscsuch as[a, c],
/// because each value ofcis distinct.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
github-actions
Bot
removed
the
documentation
alamb
enabled auto-merge
November 11, 2026 14:21
Contributor
Author
|
Thanks again @nuno-faria |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While reviewing #27191 I was researching how
EquivalencePropertiestracks orderings and groupings, and wanted to write down what I learned so others do not have to repeat it.The
GroupingEquivalenceClassdocs described the property in prose but had no example, and did not say how it relates toOrderingEquivalenceClass, which it parallels.What changes are included in this PR?
Rustdoc only, in
datafusion/physical-expr/src/equivalence/grouping.rs:Split out of a larger documentation PR (#27234) for easier review.
What is the testing strategy for this PR?
CI
Are there any user-facing changes?
No.