Repository navigation
Conversation
jayzhan211
requested changes
Nov 11, 2026
jayzhan211
left a comment
jayzhan211
left a comment
Contributor
There was a problem hiding this comment.
@Awesome06 thanks for picking this up! Two small asks inline: keep this suite's 10,000-case CI budget, and mark the newly public items #[doc(hidden)] per the API policy.
Awesome06
force-pushed
the
refactor-27082-fuzz-key-range-bitmap
branch
from
November 11, 2026 15:16
8df4e3a to
d41e729
Compare
Refactor the legacy union_fuzz test in key_range_bitmap.rs into a reproducible FuzzTest suite managed by the centralized driver in datafusion-fuzz, as part of apache#27082. - Expose KeyRangePart and KeyRangeBitmap::union with #[doc(hidden)] for fuzz testing - Add hidden offset, span, shift, and bits accessors on KeyRangeBitmap - Implement KeyRangeBitmapFuzzer in datafusion/fuzz/tests/suites/key_range_bitmap.rs - Register KeyRangeBitmapFuzzer in datafusion/fuzz/tests/fuzz.rs with 10,000 cases - Remove legacy union_fuzz and run_union_scenario from key_range_bitmap.rs - Update xtask LEGACY_FUZZ_TESTS and remove union_fuzz runner configuration
Awesome06
force-pushed
the
refactor-27082-fuzz-key-range-bitmap
branch
from
November 11, 2026 15:36
d41e729 to
865cbd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #27082.
Rationale for this change
The
union_fuzztest inkey_range_bitmap.rspreviously ran as a standalone#[test]using environment variables (DATAFUSION_KEY_RANGE_UNION_FUZZ_ITERATIONSandDATAFUSION_KEY_RANGE_UNION_FUZZ_SEED) without standardized budget controls or centralized failure reporting.Migrating this suite to the
FuzzTestframework introduced in #27048 makes failures reproducible via seed reporting, connects it to the unified runner indatafusion-fuzz, and aligns it with project-wide fuzz testing conventions.What changes are included in this PR?
datafusion-physical-plan:KeyRangePartandKeyRangeBitmap::unionsodatafusion-fuzzcan construct partitions and test union behavior.offset(&self),span(&self),shift(&self), andbits(&self)getter accessors onKeyRangeBitmapfor internal invariant checking.union_fuzzandrun_union_scenariotest functions fromkey_range_bitmap.rs.datafusion-fuzz:KeyRangeBitmapFuzzerintests/suites/key_range_bitmap.rsimplementing theFuzzTesttrait.KeyRangeBitmapFuzzerintests/fuzz.rsandtests/suites/mod.rs.xtask:union_fuzzfromLEGACY_FUZZ_TESTSinci_steps.rsand clean up legacy runner configuration and snapshots.What is the testing strategy for this PR?
datafusion-physical-planunit tests:cargo test -p datafusion-physical-plan --lib -- joins::key_range_bitmap(all 4 unit tests pass)cargo test -p datafusion-fuzz --test fuzz --features extended_tests(256 cases pass)xtasklegacy fuzz test verification:cargo test -p datafusion-xtask -- legacy_fuzz_tests_existAre there any user-facing changes?
No user-facing changes.