Repository navigation
chore(optimizer): enabling config for ReplaceFilterTop1 by default - #27305
Open
saadtajwar wants to merge 1 commit into
Open
saadtajwar wants to merge 1 commit into
saadtajwar wants to merge 1 commit into
Conversation
Contributor
Author
|
cc @zhuqi-lucas & @alamb - thanks again for the help with this! Ready for review, follow-up from #23824 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
enable_row_number_to_aggregateby default #24761Rationale for this change
ReplaceFilterTop1rewritesFilter(row_number() = 1)over aPARTITION BYwindow into afirst_valueaggregate - the rewrite was gated behinddatafusion.optimizer.enable_row_number_to_aggregate, which defaulted tofalse- this PR enables this by defaultWhat changes are included in this PR?
enable_row_number_to_aggregatedefault totrueindatafusion/common/src/config.rsand remove the “disabled by default” documentation on that optiondocs/source/user-guide/configs.mdinformation_schema.sltexpectations for the new default and description textrow_number_to_aggregate.sltcommentsReplaceFilterTop1to note the option is on by defaultAre there user-facing changes?
Yes, top-1
row_number()+filterpatterns are rewritten tofirst_valueaggregates unless the optimizer option is set tofalse.