Skip to content

fix(linker): match issue keys case-insensitively in LinkPrToIssue - #9336

Merged
klesh merged 1 commit into
apache:mainfrom
VictorColomb:fix/linker-case-insensitive-issue-key
Nov 8, 2026
Merged

klesh merged 1 commit into
apache:mainfrom
VictorColomb:fix/linker-case-insensitive-issue-key

Conversation

@VictorColomb

@VictorColomb VictorColomb commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

LinkPrToIssue compared extracted keys to issues.issue_key with an exact, case-sensitive match, so lowercase branch names like user/proj-123-title never linked to PROJ-123 (on case-sensitive DBs such as PostgreSQL).

Does this close any open issues?

Closes #9283

Other Information

Added e2e test TestLinkPrToIssueCaseInsensitive. It fails without the fix on PostgreSQL; on MySQL the default collation is already case-insensitive, so it passes either way.

@VictorColomb
VictorColomb marked this pull request as ready for review November 6, 2026 16:11

@klesh klesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh
klesh merged commit a582f31 into apache:main Nov 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][linker] LinkPrToIssue never matches lowercase issue keys (e.g. in branch names)

2 participants