Repository navigation
fix(github): return the issue extractor setup errors - #9359
Merged
Merged
Conversation
ExtractApiIssues and the github_graphql ExtractIssues returned nil when NewIssueRegexes failed, e.g. on an invalid issue regex in the scope config. The github_graphql extractor did the same when the milestone query failed. The subtask was marked successful without extracting anything, and the error was lost. Return it, like the PR extractors do. Closes apache#9358 Generated-by: Claude Code (Claude Opus 5.5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Shivam Sharma <192242476+ShivamSharma43@users.noreply.github.com>
klesh
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The GitHub
extractApiIssuesand GitHub GraphQLextractIssuessubtasks returnednilwhen their setup failed, so they were marked successful without extracting anything and the error was lost.Both extractors did this after
NewIssueRegexes, and the GraphQL extractor did it again aftergetMilestoneMap:NewIssueRegexesfails when a scope config regex (issueSeverity,issuePriority,issueTypeBug, ...) doesn't compile.getMilestoneMapfails when the_tool_github_milestonesquery fails. The pipeline then went on to convert whatever was already in_tool_github_issues, and the user wasn't told that the regex was invalid.Changes:
plugins/github/tasks/issue_extractor.go,plugins/github_graphql/tasks/issue_extractor.go:return err, like the PR extractors of both plugins.plugins/github/tasks/issue_extractor_test.go:TestExtractApiIssuesReturnsIssueRegexErrorpasses a scope config with an invalidissueSeverityregex and checks thatExtractApiIssuesreturns the error.plugins/github_graphql/tasks/issue_extractor_test.go(new): the same regex test forExtractIssues, plusTestExtractIssuesReturnsMilestoneQueryError, which makes the milestone query fail through a mockeddal.Dal.Does this close any open issues?
Closes #9358
Screenshots
N/A
Other Information
go test ./plugins/github/tasks/ ./plugins/github_graphql/tasks/: pass. The three new tests fail onmain(the extractors returnnil).go build,go vet,gofmtandgolangci-lint run ./plugins/github/... ./plugins/github_graphql/...: clean. The github and github_graphql e2e tests needE2E_DB_URL, which I didn't run locally; their scope configs have valid regexes, so they don't reach these error paths.return nilafter its setup. The GitLab issue extractor already returns its regex errors.pr-type/bug-fix.Generated-by:trailer per the ASF generative tooling guidance.🤖 Generated with Claude Code