branch-4.1: [fix](compaction) Use row count for cumulative task classification #66706 - #66938
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [fix](compaction) Use row count for cumulative task classification #66706#66938github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…66706) Problem Summary: `CompactionMixin::calc_input_rowsets_row_num()` calculated input rowset disk size instead of row count. As a result, cumulative compaction task classification compared bytes with `large_cumu_compaction_task_row_num_threshold`, which could incorrectly treat compactions with small row count but disk size over the threshold value as large tasks. This PR fixes the calculation to sum `rowset->num_rows()` and adds a BE unit test to verify row-count calculation is independent from total-size calculation. ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [✅] Unit Test - [ ] Manual test - [ ] No need to test or manual test. - Behavior changed: - [✅] No. - [ ] Yes. - Does this need documentation? - [✅] No. - [ ] Yes.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #66706