Add unit test coverage across grails-data-mongodb

[borinquenkid]

Summary

Staged pass adding unit test coverage across previously-untested surface in grails-data-mongodb, identified via a jacoco coverage report plus a systematic gap analysis of every submodule:

• ext: MongoExtensions (the module's only class - Map/Bson conversion and the full Groovy extension-method surface over the MongoDB driver)
• bson: all codecs/*Codec, codecs/decoders/*, codecs/encoders/*, CodecCustomTypeMarshaller, CodecExtensions, and the hand-written json/ parser (JsonReader/JsonWriter)
• embedded: InMemoryMongoBackend and FlapdoodleMongoBackend
• spring-data: GormSharedSessionMongoTransactionManager
• core: targeted gaps (Distance, MongoIdCoercion, AbstractMongoConnectionSourceSettings, MongoStaticApi) not already covered by the module's large functional/TCK suite

Two real JsonScanner parsing bugs turned up while writing the json-parser tests (bare exponent-notation numbers at end-of-input, -Infinity failing to parse in any context), and are fixed here too (same production change and regression test as #16284, which backports the fix to 7.0.x since the bug is present there as well).

Test plan

• Full test suite green for every touched module (ext, bson, embedded, spring-data, core), verified individually and together
• codeStyle clean for every touched module

🤖 Generated with Claude Code

https://claude.ai/code/session_01QAjfckcY4EJsxranv1RyGV

[Copilot]

Pull request overview

Expands unit test coverage across the grails-data-mongodb multi-module project (ext/bson/embedded/spring-data/core), and includes a small production fix in the BSON JSON parser (JsonScanner) discovered while adding those tests.

Changes:

• Add comprehensive Spock unit specs for previously-untested MongoDB extension-method and codec/encoder/decoder surfaces.
• Add targeted unit tests for embedded backend behaviors and Spring Data transaction manager branching logic.
• Fix two JsonScanner number-parsing edge cases (bare exponent at EOF; -Infinity parsing) with regression tests.

Reviewed changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
grails-data-mongodb/spring-data/src/test/groovy/org/grails/datastore/gorm/mongodb/springdata/GormSharedSessionMongoTransactionManagerSpec.groovy	Adds unit coverage for transaction manager resource binding/cleanup branches.
grails-data-mongodb/grails-plugin/src/test/groovy/grails/plugins/mongodb/MongodbGrailsPluginSpec.groovy	Adds unit coverage for plugin descriptor metadata and Spring bean/alias registration behavior.
grails-data-mongodb/grails-plugin/build.gradle	Adds test dependencies needed to run new plugin unit specs.
grails-data-mongodb/ext/src/test/groovy/org/grails/datastore/gorm/mongo/extensions/MongoExtensionsSpec.groovy	Adds broad unit coverage for Groovy extension-method surface over the MongoDB driver.
grails-data-mongodb/ext/build.gradle	Adds test dependencies needed to run new ext module specs.
grails-data-mongodb/embedded/src/test/groovy/org/grails/datastore/gorm/mongodb/embedded/InMemoryMongoBackendSpec.groovy	Adds unit coverage for in-memory embedded backend lifecycle and restart semantics.
grails-data-mongodb/embedded/src/test/groovy/org/grails/datastore/gorm/mongodb/embedded/FlapdoodleMongoBackendSpec.groovy	Adds unit coverage for flapdoodle backend name/availability and early validation failures.
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/mapping/mongo/engine/MongoIdCoercionSpec.groovy	Adds unit coverage for ID coercion behavior and mapping edge cases.
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/mapping/mongo/config/MongoConnectionSourceSettingsSpec.groovy	Adds tests for URL/database derivation logic in settings.
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/SwitchDatabaseAtRuntimeSpec.groovy	Extends functional/TCK-style spec coverage for database/collection switching APIs.
grails-data-mongodb/core/src/test/groovy/grails/mongodb/geo/DistanceSpec.groovy	Adds unit tests for geo Distance value semantics.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/json/JsonWriterSpec.groovy	Adds unit coverage for BSON JSON writer output, including round-trip paths with JsonReader.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/json/JsonReaderSpec.groovy	Adds unit coverage for BSON JSON reader parsing, including regression cases.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/SimpleCodecsSpec.groovy	Adds unit tests for simple codec adapters and BigDecimal/BigInteger codecs.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/encoders/TenantIdEncoderSpec.groovy	Adds unit coverage for tenant-id encoder behavior.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/encoders/TemporalTypeEncodersSpec.groovy	Adds unit coverage for temporal type encoder adapters.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/encoders/SimpleEncoderSpec.groovy	Adds unit coverage for simple type encoder dispatch/encoding behaviors.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/encoders/IdentityEncoderSpec.groovy	Adds unit coverage for identity encoder name/type handling, including edge paths.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/encoders/EmbeddedEncoderSpec.groovy	Adds unit coverage for embedded association encoding behavior.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/encoders/EmbeddedCollectionEncoderSpec.groovy	Adds unit coverage for embedded collection encoding behavior.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/encoders/CustomTypeEncoderSpec.groovy	Adds unit coverage for custom type encoding behavior (codec-backed and marshaller-backed).
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/encoders/BasicCollectionTypeEncoderSpec.groovy	Adds unit coverage for basic collection encoder behavior and dirty-check wrapping.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/decoders/TenantIdDecoderSpec.groovy	Adds unit coverage for tenant-id decoder behavior.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/decoders/TemporalTypeDecodersSpec.groovy	Adds unit coverage for temporal type decoder adapters.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/decoders/SimpleDecoderSpec.groovy	Adds unit coverage for simple type decoder dispatch/decoding behaviors.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/decoders/IdentityDecoderSpec.groovy	Adds unit coverage for identity decoder behavior and error paths.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/decoders/EmbeddedDecoderSpec.groovy	Adds unit coverage for embedded association decoding behavior.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/decoders/EmbeddedCollectionDecoderSpec.groovy	Adds unit coverage for embedded collection decoding behavior.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/decoders/CustomTypeDecoderSpec.groovy	Adds unit coverage for custom type decoding behavior (codec-backed and marshaller-backed).
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/decoders/BasicCollectionTypeDecoderSpec.groovy	Adds unit coverage for basic collection decoding and conversion behavior.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/CodecExtensionsSpec.groovy	Adds unit coverage for codec extension provider behavior and BSON conversion helpers.
grails-data-mongodb/bson/src/test/groovy/org/grails/datastore/bson/codecs/CodecCustomTypeMarshallerSpec.groovy	Adds unit coverage for codec-backed custom type marshaller behavior and unsupported operations.
grails-data-mongodb/bson/src/main/groovy/org/grails/datastore/bson/json/JsonScanner.java	Fixes numeric scanning edge cases and supports exponent termination at EOF.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[testlens-app]

🚨 TestLens detected 2 failed tests 🚨

Here is what you can do:

1. Inspect the test failures carefully.
2. If you are convinced that some of the tests are flaky, you can mute them below.
3. Finally, trigger a rerun by checking the rerun checkbox.

Test Summary

CI / Functional Tests (Java 21, indy=true) > :grails-test-examples-scaffolding:integrationTest

Test	Runs	Flakiness
UserControllerSpec > User list	❌	3% 🟡

Groovy Snapshot Canary Build / Build Grails (shard 2) > :grails-data-mongodb:test

Test	Runs	Flakiness
MongodbGrailsPluginSpec > exposes the expected Grails plugin descriptor metadata	❌	0% 🟢

🏷️ Commit: 06fde1d
▶️ Tests: 69145 executed
⚪️ Checks: 84/84 completed

Test Failures

MongodbGrailsPluginSpec > exposes the expected Grails plugin descriptor metadata (:grails-data-mongodb:test in Groovy Snapshot Canary Build / Build Grails (shard 2))

Condition not satisfied:

plugin.organization == [name: 'Grails', url: 'https://grails.apache.org/']
|      |            |
|      |            false
|      [name:Apache Grails, url:https://grails.apache.org/]
<grails.plugins.mongodb.MongodbGrailsPlugin@31c9bb2f license=inaccessible organization=inaccessible issueManagement=inaccessible scm=inaccessible grailsVersion=inaccessible observe=inaccessible loadAfter=inaccessible title=inaccessible description=inaccessible documentation=inaccessible version=inaccessible grailsApplication=inaccessible plugin=inaccessible pluginManager=inaccessible environment=inaccessible enabled=true artefacts=inaccessible applicationContext=inaccessible>

	at grails.plugins.mongodb.MongodbGrailsPluginSpec.exposes the expected Grails plugin descriptor metadata(MongodbGrailsPluginSpec.groovy:52)

expected	actual
name: Grails	name: Apache Grails
url: https://grails.apache.org/	url: https://grails.apache.org/

UserControllerSpec > User list (:grails-test-examples-scaffolding:integrationTest in CI / Functional Tests (Java 21, indy=true))

geb.waiting.WaitTimeoutException: condition did not pass in 30 seconds (failed with exception)
	at geb.waiting.Wait.waitFor(Wait.groovy:128)
	at geb.waiting.DefaultWaitingSupport.doWaitFor(DefaultWaitingSupport.groovy:55)
	at geb.waiting.DefaultWaitingSupport.waitFor(DefaultWaitingSupport.groovy:41)
	at geb.Page.waitFor(Page.groovy:120)
	at com.example.pages.LoginPage.login(LoginPage.groovy:39)
	at com.example.UserControllerSpec.User list(UserControllerSpec.groovy:48)
Caused by: Assertion failed: 

title != pageTitle && $('input', name: 'username').empty
|     |  |         |
|     |  |         false
|     |  'Please sign in'
|     false
'Please sign in'

	at com.example.pages.LoginPage.login_closure1(LoginPage.groovy:39)
	at com.example.pages.LoginPage.login_closure1(LoginPage.groovy)
	at geb.waiting.Wait.waitFor(Wait.groovy:117)
	... 5 more

Rerun Controls

Select tests to mute in this pull request:

• MongodbGrailsPluginSpec > exposes the expected Grails plugin descriptor metadata
• UserControllerSpec > User list

Reuse successful test results:

• ♻️ Only rerun the tests that failed or were muted before

Click the checkbox to trigger a rerun:

• Rerun jobs

---

Learn more about TestLens at testlens.app/docs.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.8834%. Comparing base (75cd618) to head (06fde1d).
⚠️ Report is 1168 commits behind head on 8.1.x.

Additional details and impacted files

@@                 Coverage Diff                 @@
##                8.1.x     #16285         +/-   ##
===================================================
- Coverage     53.4149%   29.8834%   -23.5315%     
+ Complexity      19459        509      -18950     
===================================================
  Files            2081         79       -2002     
  Lines           98993       4715      -94278     
  Branches        17361        814      -16547     
===================================================
- Hits            52877       1409      -51468     
+ Misses          38566       3063      -35503     
+ Partials         7550        243       -7307     

see 2036 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.