Repository navigation
Conversation
- Introduce GraphKey for graph-space and graph-name identity. - Migrate registry and lifecycle tracking to typed keys. - Preserve string boundaries and the live graph-name view. - Add registry regressions and adapt existing lifecycle fixtures.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3482 +/- ##
============================================
+ Coverage 58.52% 58.65% +0.13%
- Complexity 2717 3096 +379
============================================
Files 779 780 +1
Lines 69439 69645 +206
Branches 9577 9708 +131
============================================
+ Hits 40637 40849 +212
- Misses 25108 25114 +6
+ Partials 3694 3682 -12
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: GraphKey replaces every string registry key in GraphManager with matching behaviour under the graph and graph space naming rules, and the 128 focused GraphManager unit tests pass at this head.
imbajin
left a comment
There was a problem hiding this comment.
Score: 8.2/10 · Confidence: medium
Blocking: no
Summary
No new actionable regression confirmed in the typed graph registry conversion.
Evidence
Traced registry creation, lookup, removal and reload, the live names view, metadata string boundaries, and graph-name validation. The latter excludes the delimiter from graph names.
Validation notes
Live PD events and multi-node lifecycle behavior were not independently tested. An older event parser still splits hyphenated graph-space names; an introduced regression was not established. Approval is withheld pending those integration checks.
- Validate parsed graph-space and graph-name components. - Reuse GraphKey for update metadata lookup and logging. - Cover normal, hyphenated, malformed and unknown event names.
|
Hi @imbajin, thanks for your valuable review. I updated Also I ran a real local cluster with one PD, one Store, and two Servers. |
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: GraphKey replaces every string key in the GraphManager registry and PD event handlers, including graphUpdateHandler, and parses the same parts as before for all valid graph and graph space names. UnitTestSuite passes at this head with GraphManagerGraphKeyTest included.
imbajin
left a comment
There was a problem hiding this comment.
Score: 8.2/10 · Confidence: medium
Blocking: no
Summary
No new actionable issue found in the typed graph registry and metadata update changes.
Evidence
Reviewed graph-key conversion across registry lifecycle and metadata boundaries. The latest update handler now uses the parsed key for metadata lookup, and graph-name validation excludes the separator. New tests cover update handling and graph-space names with separators.
Validation notes
No tests or distributed PD/Store integration were independently run in this review. The author's reported multi-node checks were not independently reproduced.
|
@imbajin Thanks for the follow-up review. Here are the details and recorded results from my latest local multi-Server verification. Environment and tested source
Verification methodI used a temporary Python script to send requests through Server A and check the resulting behavior on Server B:
Checking B's logs before graph lookups avoids counting lazy graph loading as proof of ADD notification propagation. ResultsAll 17 scripted functional checkpoints passed. These are checkpoints in one cluster run, not 17 existing project test cases or separate deployments.
Example ADD evidence from Server B, before querying the graph: Example read-mode update evidence: B then returned Scripts and recorded outputI am uploading the scripts and recorded output individually, using their original file extensions.
ReproductionWith Java 17 and Maven available, use a separate source checkout at export HUGEGRAPH_SOURCE="$PWD"
mvn package \
-pl hugegraph-server/hugegraph-dist,hugegraph-pd/hg-pd-dist,hugegraph-store/hg-store-dist \
-am -Dmaven.test.skip=true -Dmaven.javadoc.skip=truePlace the three Python scripts in a fresh writable directory outside the checkout. With Python 3, PyYAML and the listed ports available: python3 run_retry.pyThe launcher generates a fresh local PD REST secret. Server REST authentication is disabled for this loopback-only setup. The uploaded launcher has been adapted to accept This verifies the listed local multi-Server functional scenarios. No integration-test or CI code is added to this PR. |
Purpose of the PR
Address the GraphManager FIXME by replacing combined string keys with typed graph identities.
In
GraphManagerthere is a comment to ask for fix:Main Changes
Verifying these changes
128 focused tests passed, including four new regression tests. Formatting, full clean compilation, and git diff --check passed.
Does this PR potentially affect the following parts?
Documentation Status