Repository navigation
Conversation
- point -pl at hugegraph-server/hugegraph-dist in CONTRIBUTING.md - make the same change in AGENTS.md - the old command only built the root and server parent POMs, so no server module or distribution was built (Issue 3484)
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: -pl hugegraph-server/hugegraph-dist -am matches what run-api-test.sh and server-tests.yml build, and the old -pl hugegraph-server -am selects only the root and hugegraph-server parent POMs. At this head, mvn clean package -DskipTests -pl hugegraph-server/hugegraph-dist -am on JDK 17 builds all 20 reactor projects and produces hugegraph-server/apache-hugegraph-server-1.8.0 with the core, api, rocksdb, hbase and hstore jars.
imbajin
left a comment
There was a problem hiding this comment.
Score: 9.0/10 · Confidence: high
Blocking: no
Summary
The distribution selector builds the server modules and their reactor dependencies; no new issues found.
Evidence
The distribution POM declares the server modules and the existing API test script uses the same project selector. The author and another reviewer report successful builds.
Validation notes
I did not independently run Maven or inspect a freshly built distribution.
Purpose of the PR
The server build command in
docs/CONTRIBUTING.mdandAGENTS.mduses-pl hugegraph-server -am, which only builds the root andhugegraph-serverparent POMs. No server module or distribution is built.Main Changes
-plathugegraph-server/hugegraph-distin both files, the same modulerun-api-test.shbuilds.AGENTS.md, so it should not get in the way of docs: streamline repository and Helm navigation #3471.Verifying these changes
Ran both commands on master (JDK 17, Maven 3.10.0): the old one builds 2 projects, the new one builds 20 and produces
hugegraph-server/apache-hugegraph-server-1.8.0.Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO: required documentation is pending; complete it before merging.Doc - Done: documentation is included here or linked below.Doc - No Need: no user-visible documentation is affected.The website docs (hugegraph-doc) don't have this command.