feat(rest): support configurable page sizes - #3168
Draft
alexanderbianchi wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2934.
What changes are included in this PR?
rest-page-sizefor namespace and table listings, resolving server defaults, client configuration, and server overrides in that order.REST_CATALOG_PROP_PAGE_SIZEandwith_page_size(u32)to both REST catalog builders. Properties passed toloadtake precedence over the builder setter.pageSizeunset when no source configures it.pageSizeon every page request and an empty initialpageTokento opt into pagination, while continuing to collect all results.Cataloginterface; no REST-specific production dependency or separate pagination setting is introduced.Are these changes tested?
information_schema.tables.cargo test -p iceberg-catalog-rest -p iceberg-datafusion --lib --tests: 181 tests passed.cargo clippy -p iceberg-catalog-rest -p iceberg-datafusion --all-targets -- -D warnings: passed.git diff --check, and the generated REST public API snapshot were checked.AI Disclosure
The implementation, tests, and documentation were developed with assistance from an AI coding agent.