Skip to content

Fix fail-open authorization for pipe config plans - #18488

Merged
jt2594838 merged 5 commits into
masterfrom
fix/config-pipe-plan-authorization
Aug 24, 2026
Merged

Fix fail-open authorization for pipe config plans#18488
jt2594838 merged 5 commits into
masterfrom
fix/config-pipe-plan-authorization

Deduplicate pipe plugin path validation

5a3d16f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Aug 24, 2026 in 7m 52s

Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 307 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/util/LoadUtil.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFnSvbYX779Bcjtql&open=AaAUFnSvbYX779Bcjtql&pullRequest=18488

Check warning on line 150 in iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a thread-safe type; adding "volatile" is not enough to make this field thread-safe. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAx1Ncv3XlTMndGW0gV&open=AaAx1Ncv3XlTMndGW0gV&pullRequest=18488

Check failure on line 958 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFna9bYX779Bcjtqu&open=AaAUFna9bYX779Bcjtqu&pullRequest=18488

Check warning on line 842 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'catch rcurly' has incorrect indentation level 12, expected level should be 10. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFna9bYX779Bcjtq9&open=AaAUFna9bYX779Bcjtq9&pullRequest=18488

Check warning on line 121 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/protocol/thrift/async/handler/PipeTransferTsFileHandler.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Constructor has 10 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFnXubYX779Bcjtqq&open=AaAUFnXubYX779Bcjtqq&pullRequest=18488

Check warning on line 839 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'catch' child has incorrect indentation level 14, expected level should be 12. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFna9bYX779Bcjtq6&open=AaAUFna9bYX779Bcjtq6&pullRequest=18488

Check warning on line 667 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFnfTbYX779Bcjtq-&open=AaAUFnfTbYX779Bcjtq-&pullRequest=18488

Check warning on line 311 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/payload/evolvable/request/PipeTransferTsFileSealWithModReq.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 8 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFnZbbYX779Bcjtqs&open=AaAUFnZbbYX779Bcjtqs&pullRequest=18488

Check warning on line 673 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/FileUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'IllegalArgumentException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAx1M133XlTMndGW0gR&open=AaAx1M133XlTMndGW0gR&pullRequest=18488

Check failure on line 214 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/util/LoadUtil.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 23 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFnSvbYX779Bcjtqk&open=AaAUFnSvbYX779Bcjtqk&pullRequest=18488

Check warning on line 766 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'catch' child has incorrect indentation level 14, expected level should be 12. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFna9bYX779Bcjtq1&open=AaAUFna9bYX779Bcjtq1&pullRequest=18488

Check failure on line 186 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusSubscriptionSetupHandler.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "root." 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAx1NZx3XlTMndGW0gU&open=AaAx1NZx3XlTMndGW0gU&pullRequest=18488

Check warning on line 185 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/converter/PipeTsFileConversionTaskManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '149'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFnR0bYX779Bcjtqi&open=AaAUFnR0bYX779Bcjtqi&pullRequest=18488

Check warning on line 141 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/active/ActiveLoadTsFileLoader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the "AtomicReference" API for synchronization instead of a "synchronized" block. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAx1NGu3XlTMndGW0gT&open=AaAx1NGu3XlTMndGW0gT&pullRequest=18488

Check failure on line 89 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/converter/LoadTableStatementDataTypeConvertExecutionVisitor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this "try" to a try-with-resources. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFnRnbYX779Bcjtqf&open=AaAUFnRnbYX779Bcjtqf&pullRequest=18488

Check warning on line 866 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/receiver/IoTDBFileReceiver.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove these unused method parameters "req", "loadStatus". 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFm2QbYX779Bcjtqa&open=AaAUFm2QbYX779Bcjtqa&pullRequest=18488

Check warning on line 830 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'try' has incorrect indentation level 12, expected level should be 10. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFna9bYX779Bcjtq4&open=AaAUFna9bYX779Bcjtq4&pullRequest=18488

Check warning on line 148 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/converter/PipeTsFileConversionTaskManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Single-line Javadoc comment should be multi-line. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFnR0bYX779Bcjtqh&open=AaAUFnR0bYX779Bcjtqh&pullRequest=18488

Check warning on line 764 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'catch' child has incorrect indentation level 14, expected level should be 12. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFna9bYX779Bcjtqz&open=AaAUFna9bYX779Bcjtqz&pullRequest=18488

Check warning on line 316 in iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the "AtomicLong" API for synchronization instead of a "synchronized" block. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAx1Ncv3XlTMndGW0gW&open=AaAx1Ncv3XlTMndGW0gW&pullRequest=18488

Check warning on line 841 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'catch' child has incorrect indentation level 14, expected level should be 12. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFna9bYX779Bcjtq8&open=AaAUFna9bYX779Bcjtq8&pullRequest=18488

Check failure on line 89 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/converter/LoadTreeStatementDataTypeConvertExecutionVisitor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this "try" to a try-with-resources. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFnQ-bYX779Bcjtqd&open=AaAUFnQ-bYX779Bcjtqd&pullRequest=18488

Check warning on line 128 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/active/ActiveLoadPathHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 9 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFnQNbYX779Bcjtqc&open=AaAUFnQNbYX779Bcjtqc&pullRequest=18488

Check warning on line 840 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'catch' child has incorrect indentation level 14, expected level should be 12. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFna9bYX779Bcjtq7&open=AaAUFna9bYX779Bcjtq7&pullRequest=18488

Check warning on line 1220 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/receiver/protocol/IoTDBConfigNodeReceiver.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge the previous cases into this one using comma-separated label. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaAUFngVbYX779Bcjtq_&open=AaAUFngVbYX779Bcjtq_&pullRequest=18488
View more details on SonarQubeCloud