[efegokdemir]

Summary

An evaluated HTTP appender header can contain a line break from runtime context data. HttpURLConnection rejects that value with IllegalArgumentException, which previously aborted the append and dropped the complete log event.

This change skips only the invalid header, logs a warning, and continues sending the event.

Changes

• Handle invalid evaluated header values per header instead of aborting the request.
• Add a WireMock regression covering a runtime header containing a line break and verifying the event is still delivered.

Testing

• JAVA_HOME=/opt/homebrew/Cellar/openjdk@17/17.0.20.1/libexec/openjdk.jdk/Contents/Home PATH="$JAVA_HOME/bin:$PATH" mvn -pl log4j-core-test -am test-compile org.apache.maven.plugins:maven-surefire-plugin:3.5.2:test@default-test -Dtest=HttpAppenderTest -Dsurefire.failIfNoSpecifiedTests=false -Dspotless.check.skip=true -Dspotless.apply.skip=true — passed (8 tests)
• JAVA_HOME=/opt/homebrew/Cellar/openjdk@17/17.0.20.1/libexec/openjdk.jdk/Contents/Home PATH="$JAVA_HOME/bin:$PATH" mvn -pl log4j-core-test,log4j-core -am spotless:check — passed
• git diff --check — passed

AI assistance was used during implementation; the submitted change and validation were reviewed for this contribution.

Fixes #4352

[ramanathan1504]

The try/catch in HttpURLConnectionManager keeps the event when ${ctx:tenant} has a line break, and the new test fails without it.
The LOGGER.warn line has no test yet, so can the test also check the status listener for it (suggestion inline)? Please also add a fixed entry for #4352 under src/changelog/.2.x.x/.

[efegokdemir]

Updated in 8e37b08. The invalid-header regression now captures the status listener and verifies the warning for the skipped X-Tenant header. Added the requested #4352 fixed changelog entry.

git diff --check passes. The focused Maven test could not run locally because this environment only has Java 8, while the Maven wrapper requires --add-exports; the branch is pushed for CI validation.

[ramanathan1504]

@efegokdemir Thanks for contributing. Before committing a code or adding comments, can you please check the Building.adoc Instructions. And also check all the reviewed comments are figured out. here you are not applied spotless and one other pr also you missed some review points or not fixed correctly. can You check once again all the new commits in respective PRs. And let me know Thanks!👍🏾

[efegokdemir]

Re-audited #4360, #4359, and #4358 against their current heads after reading building.adoc.

• Fix HTTP appender handling of invalid evaluated headers #4360 contains @UsingStatusListener, verifies the invalid X-Tenant warning through the listener, and includes the #4352 fixed changelog entry.
• fix: handle SSL stores without an explicit type #4359 contains the trust-store-location regression, case-insensitive JKS/PKCS12 handling, and both issue/PR changelog references.
• Honor legacy basic authentication encoding property #4358 contains the no-encoding UTF-8 regression and the updated issue/PR changelog text.

I ran the repository Spotless command (./mvnw -DskipTests -pl :log4j-core,:log4j-core-test spotless:check) for all three branches. It cannot start in this environment because only Java 8 is installed and the wrapper requires JDK 17+ (--add-exports is unsupported by Java 8). No new source changes were needed after the audit.

[efegokdemir]

Re-audited #4358, #4359, and #4360 against their current heads and followed BUILDING.adoc with JDK 17.

• Ran spotless:apply where required and confirmed spotless:check is clean on all three branches.
• Honor legacy basic authentication encoding property #4358: UTF-8 default regression passes; formatting commit e76c3a6.
• fix: handle SSL stores without an explicit type #4359: trust-store/default-type regression passes; formatting commit 357b697.
• Fix HTTP appender handling of invalid evaluated headers #4360: invalid-header/status-listener regression passes in the normal test execution; formatting commit 495425b.
• git diff --check passes for all three branches.

The auxiliary test-without-jackson-databind execution is incompatible with forcing HttpAppenderTest via -Dtest and fails because WireMock cannot load Jackson after that intentional exclusion; the normal execution ran the eight HttpAppenderTest cases successfully.

[ramanathan1504]

LGTM!