Skip to content

Migrate remaining log4j-api-test unit tests to JUnit 5 - #4434

Open
Shekharrajak wants to merge 2 commits into
apache:2.xfrom
Shekharrajak:fix/4430-api-test-junit5
Open

Shekharrajak wants to merge 2 commits into
apache:2.xfrom
Shekharrajak:fix/4430-api-test-junit5

Conversation

@Shekharrajak

Copy link
Copy Markdown

Fixes #4430.

LoaderUtilSecurityManagerTest and MessageFormatMessageSerializationTest
were silently skipped because log4j-api-test has no JUnit Vintage engine.
Migrate both to Jupiter, restoring execution of all seven test cases.

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (the build instructions)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests are provided

type="changed">
<issue id="4430" link="https://github.com/apache/logging-log4j2/issues/4430"/>
<description format="asciidoc">
Migrate the remaining `log4j-api-test` unit tests to JUnit 5 so they execute without the JUnit Vintage engine.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XML files to generate release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Migrate log4j-api-test tests to JUnit 5

1 participant