Prevent content from steering the string match filters - #317
Merged
Conversation
- Logging an empty message threw IndexOutOfRangeException: the branch meant for a one-character message read message[0] without checking there was one. - AppenderSkeleton caught it, so the event simply disappeared. - The reset codes now go at one computed offset, leaving no short-message branch to get wrong. - All ten line-break cases are pinned by test. They carry explicit names because dotnet test --filter cannot see them otherwise; CLAUDE.md records why. audit da18b6f-f029
#316 - Reading HttpRequest.Params validates the query string, form and cookies on first access, so a request carrying <script> threw inside the layout and AppenderSkeleton discarded the whole event: a sender could suppress the log record of their own request. - The converter now reads through HttpRequest.Unvalidated, so the content is kept rather than replaced by the not-available marker. - The try now also covers the body parse and ServerVariables, which throw on an oversized body or a lost client. Verified on Windows: with no worker request behind it, ServerVariables is empty rather than throwing. - Five tests, net462 only, so they run on the Windows leg alone. Reverting the fix fails exactly the two that assert the content survives. audit da18b6f-f019
CLAUDE.md wants the description to close with both sides, who raised it and who did the work. Eleven entries named only the audit finding. Nothing but the attribution changed.
The Ext.Mail send rework answers f004 and the remote syslog queue and pump work answers f034, but neither pair named the finding. The other five 314 and 315 entries stay unattributed: they are our own, not audit findings.
- Substring matching was culture sensitive, so a NUL, soft hyphen or zero-width space inside StringToMatch still matched. Ordinal now. - An abandoned regex match counted as a non-match, so content that forced the timeout could suppress its own record. TimeoutDecision decides it, still Neutral by default. - Default deadline 1000ms to 50ms. The match holds the appender lock. - StringMatchFilter and PropertyFilter had near-identical Decide bodies, which is why each finding existed twice. Shared now. - filters.adoc documented the old deadline and outcome, and had an example restoring the old default. MdcFilter and NdcFilter derive from PropertyFilter and need no change. audit da18b6f-f017, da18b6f-f018, da18b6f-f041
FreeAndNil
marked this pull request as ready for review
September 4, 2026 11:50
gdziadkiewicz
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three findings, one commit: all three sit in
StringMatchFilter, whoseDecidewas a near-duplicate of
PropertyFilter.Decide, so each defect existed at twosites. Both now share one implementation, which is also why
MdcFilterandNdcFilterneed no change.skips ignorable characters, so content holding a NUL, a soft hyphen or a
zero-width space between the letters of
stringToMatchstill matched it, andthe decision varied with the host culture. Ordinal now, so the filter decides
the same way a reader of the log would.
decides whether the deadline is reached, so in an
AcceptOnMatchallowlistending in a
DenyAllFilter, content could suppress its own record. The newtimeoutDecisiondecides those events, stillNeutralby default;Acceptmakes such a chain fail towards logging.
matchTimeoutMillisdrops from 1000 to 50. The match runsunder the appender lock, so the deadline bounds what one crafted event costs
every other logging thread. A legitimate match takes a fraction of that.
filters.adocdocumented the old deadline and outcome, and its example set thevalue back to 1000; both corrected, and
timeoutDecisionis documented againstthe allowlist arrangement the same page recommends.
Deliberate default change: f041. An operator whose pattern genuinely needs
longer must now set
matchTimeoutMillis, and gets the existing once-per-filterwarning if a match is abandoned.
Tests: 13 new across both filters, and each fix was checked by reverting it and
confirming the right tests fail (5 for f018, 3 for f017, 1 for f041).