Repository navigation
test(adversarial-review): give the timing tests room to start their stubs - #1699
Merged
Merged
Conversation
test_one_timeout_does_not_block_the_others ran both stub reviewers with a one-second budget, and the one meant to answer is a Python process that has to start first. On a loaded machine (the parallel pre-commit pytest run) start-up alone took longer, so the answering reviewer timed out too and the test failed. Give it five seconds; the other stub still sleeps for a minute, so the timeout case is unchanged. Generated-by: Claude Opus 5
Two more runner tests measured wall-clock time against bounds that left little room for starting the Python stubs, and one failed under the parallel pre-commit pytest run (3.03 s against 2.8 s): - the parallel run sleeps 3 s per reviewer and must finish under 5.5 s (6 s one after the other), not 1.5 s under 2.8 s; - a finished answer with a lingering helper must arrive under 8 s with a 10 s timeout, not under 4 s with 5 s. Each test still tells the behaviour apart from its failure mode. Generated-by: Claude Opus 5
github-actions
Bot
added
family:tools
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three adversarial-review runner tests measure wall-clock time against bounds that left too little room for starting the Python stub reviewers.
Under load (the pre-commit hook runs the workspace pytest members in parallel) they failed intermittently and blocked unrelated commits.
test_one_timeout_does_not_block_the_others: the reviewer that should answer had a 1 s budget, which its own start-up could use up. It now has 5 s; the other stub still sleeps for a minute, so it still times out.test_reviewers_run_in_parallel_and_keep_order: two 1.5 s reviewers had to finish under 2.8 s (3.03 s seen). Now 3 s each under 5.5 s; one after the other they take 6 s.test_a_finished_answer_is_kept_when_a_helper_lingers: under 8 s with a 10 s timeout instead of under 4 s with 5 s.Each test still tells the behaviour apart from its failure mode. Test-only change.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines
🤖 Generated with Claude Code