Repository navigation
feat(setup): first-run welcome guide for the contributor-growth family (#1658) - #1702
Merged
potiuk merged 3 commits intoOct 19, 2026
Merged
Conversation
Kaap10
force-pushed
the
feat/welcome-guide-contributor-growth-1658
branch
from
October 19, 2026 03:31
c4080d2 to
1138403
Compare
Contributor
Author
|
Ready for review! |
apache#1658) Adds a concise first-run welcome guide for the contributor-growth skill family (activity-sweep, calibrate, candidate-screen, committer-onboarding, contributor-to-committer, identity-map, nomination, onboarding-concierge, and sentiment), following the pattern established in apache#1653 and apache#1663. - Adds plugins/magpie-setup/skills/setup/setup_preflight/guides/contributor-growth.md - Highlights typical flow across 7 steps and notes private list / calibrated thresholds - Links the guide from docs/contributor-growth/README.md under Install & first runs - Adds case-11-contributor-growth-first-run preflight-floor fixture and updates case-9 - Expands test_welcome.py test coverage and updates total eval case counts
Kaap10
force-pushed
the
feat/welcome-guide-contributor-growth-1658
branch
from
October 19, 2026 04:43
1138403 to
05f8773
Compare
9 of 22 tasks
The guide's "Configure it" section described private-list access and thresholds without naming a file to configure. It now names the file each skill reads (`committer-readiness.md`, `contributor-nomination-config.md`, the onboarding and sentiment configs, and `privacy-llm.md` for the private-list reads), and says `setup config` configures rather than "personal install". Every other family guide has a test that the family's skills resolve to it and that it follows the general guide on the next run; this family now has one too. The case-11 fixture that embeds the guide is re-rendered. Generated-by: Claude Opus 5
…702-fixup Generated-by: Claude Opus 5 # Conflicts: # tools/setup-preflight/tests/test_welcome.py # tools/skill-evals/README.md # tools/skill-evals/evals/setup/README.md # tools/skill-evals/evals/setup/preflight-floor/fixtures/case-9-first-magpie-run/report.md
potiuk
approved these changes
Oct 19, 2026
potiuk
left a comment
Member
There was a problem hiding this comment.
Adds the contributor-growth welcome guide covering all nine skills, with the standard README block; the skills and the flow it describes check out.
I pushed two commits rather than send this round again:
- bd56c7e — fixup. "Configure it" described private-list access and thresholds without naming a file to configure; it now names the file each skill reads (
committer-readiness.md,contributor-nomination-config.md,committer-onboarding-config.md,onboarding-concierge-config.md,contributor-sentiment-config.md, andprivacy-llm.mdfor calibration's private-list reads), and says/magpie-setup:setup configconfigures rather than "personal install". I also added the next-run test every other family guide has: the nine skills resolve tocontributor-growth, and the guide follows the general one on the next run. - b48fa50 — merge of
main. The mentoring, pairing, issue and PR-management guides landed first and claimed the same slots, so this fixture is nowcase-15-contributor-growth-first-run, the setup case counts go to 135, the test lists carry every family, and thecase-9report is re-rendered.
The PR merges automatically once CI is green. Thanks for the guide!
This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Magpie handles maintainer review:
Contributing guide.
potiuk
enabled auto-merge (squash)
October 19, 2026 20:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contributor-growthskill family (plugins/magpie-setup/skills/setup/setup_preflight/guides/contributor-growth.md), following the template established in feat(setup): first-run welcome guides, general and for the security skills #1653 and Welcome guide: utilities family #1663.activity-sweep→identity-map→contributor-to-committer→nomination→candidate-screen→committer-onboarding;sentiment), highlighting private governance (<private-list>confidentiality), calibrated thresholds, and the core principle: information only, never a readiness verdict.calibrateandonboarding-concierge.case-11-contributor-growth-first-run, re-renderscase-9-first-magpie-runto includecontributor-growthin the general guide, links the guide indocs/contributor-growth/README.md, and expands test coverage intest_welcome.py.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek runstatic checks pass (markdownlint, mixed-line-ending, doctoc, add-license-headers)pytestandruff checkpass cleanly(
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
python tools/dev/render-preflight-fixtures.py --checkpasses with zero drift;pytest tools/setup-preflight/tests/test_welcome.pypasses (50 tests).RFC-AI-0004 compliance
<PROJECT>,<tracker>,<upstream>,<security-list>,<private-list>) used in all skill / tool prose (thecheck-placeholdersprek hook is the mechanical gate)Linked issues
Closes #1658 (child of #1654)
Notes for reviewers (optional)
test_each_guide_is_short_and_ends_with_the_way_back.case-11uses the exactsurface_hash(sha256:bdf92c88a304ddea) declared bycontributor-to-committer.case-11andcase-9report fixtures were dynamically generated viarender-preflight-fixtures.pyensuring zero drift.