Skip to content

feat(setup): first-run welcome guide for the contributor-growth family (#1658) - #1702

Merged
potiuk merged 3 commits into
apache:mainfrom
Kaap10:feat/welcome-guide-contributor-growth-1658
Oct 19, 2026
Merged

potiuk merged 3 commits into
apache:mainfrom
Kaap10:feat/welcome-guide-contributor-growth-1658

Conversation

@Kaap10

@Kaap10 Kaap10 commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a first-run welcome guide for the contributor-growth skill family (plugins/magpie-setup/skills/setup/setup_preflight/guides/contributor-growth.md), following the template established in feat(setup): first-run welcome guides, general and for the security skills #1653 and Welcome guide: utilities family #1663.
  • Introduces the typical contributor-growth flow (activity-sweep → identity-map → contributor-to-committer → nomination → candidate-screen → committer-onboarding; sentiment), highlighting private governance (<private-list> confidentiality), calibrated thresholds, and the core principle: information only, never a readiness verdict.
  • Provides plain-language invocation prompts across all 9 skills in the family, including calibrate and onboarding-concierge.
  • Adds preflight-floor eval case-11-contributor-growth-first-run, re-renders case-9-first-magpie-run to include contributor-growth in the general guide, links the guide in docs/contributor-growth/README.md, and expands test coverage in test_welcome.py.

Type of change

  • Skill change (.claude/skills/<name>/) — eval fixtures updated below
  • Tool / bridge contract (tools/<system>/*.md)
  • Python package (tools/*/ with pyproject.toml)
  • Groovy reference impl
  • Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
  • Documentation (docs/, README.md, CONTRIBUTING.md)
  • Project template (projects/_template/)
  • CI / dev loop (prek, workflows, validators)
  • Other: Framework setup preflight welcome guide

Test plan

  • prek run static checks pass (markdownlint, mixed-line-ending, doctoc, add-license-headers)
  • For Python packages touched: pytest and ruff check pass cleanly
  • For Groovy bridges touched: command-line invocation tested end-to-end
  • For skill changes: eval suite passes for the affected skill
    (PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)
  • For skill behaviour changes: a new or updated eval fixture is included in this PR
    (a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
  • Other: python tools/dev/render-preflight-fixtures.py --check passes with zero drift; pytest tools/setup-preflight/tests/test_welcome.py passes (50 tests).

RFC-AI-0004 compliance

  • HITL — any new mutation is gated on explicit user confirmation
  • Sandbox — no new unrestricted host access; network reach declared in the adapter
  • Vendor neutrality — placeholders (<PROJECT>, <tracker>, <upstream>, <security-list>, <private-list>) used in all skill / tool prose (the check-placeholders prek hook is the mechanical gate)
  • Conversational + correctable — agentic-override path documented if behaviour is adopter-tunable
  • Write-access discipline — no autonomous outbound messages; drafts only, sent on confirmation
  • Privacy LLM — private content does not reach a non-approved LLM; redactor invoked where needed

Linked issues

Closes #1658 (child of #1654)

Notes for reviewers (optional)

  • The guide is 54 lines of Markdown, well under the 70-line limit enforced by test_each_guide_is_short_and_ends_with_the_way_back.
  • case-11 uses the exact surface_hash (sha256:bdf92c88a304ddea) declared by contributor-to-committer.
  • Both case-11 and case-9 report fixtures were dynamically generated via render-preflight-fixtures.py ensuring zero drift.

@github-actions github-actions Bot added family:setup setup-* skills family:tools tools/* family:docs Docs, MISSION.md, READMEs capability:platform Framework / agent substrate skills (install, verify, doctor, override, status, setup bootstrap) family:contributor-growth contributor-growth skills substrate:framework-dev Tool substrate: build / validate / eval the framework itself substrate:setup Tool substrate: adopter-side setup state resolved at runtime (lock parsing, floors, fingerprints) labels Oct 19, 2026
@Kaap10
Kaap10 force-pushed the feat/welcome-guide-contributor-growth-1658 branch from c4080d2 to 1138403 Compare October 19, 2026 03:31
@Kaap10

Kaap10 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor Author

Ready for review!

apache#1658)

Adds a concise first-run welcome guide for the contributor-growth skill family (activity-sweep, calibrate, candidate-screen, committer-onboarding, contributor-to-committer, identity-map, nomination, onboarding-concierge, and sentiment), following the pattern established in apache#1653 and apache#1663.

- Adds plugins/magpie-setup/skills/setup/setup_preflight/guides/contributor-growth.md
- Highlights typical flow across 7 steps and notes private list / calibrated thresholds
- Links the guide from docs/contributor-growth/README.md under Install & first runs
- Adds case-11-contributor-growth-first-run preflight-floor fixture and updates case-9
- Expands test_welcome.py test coverage and updates total eval case counts
@Kaap10
Kaap10 force-pushed the feat/welcome-guide-contributor-growth-1658 branch from 1138403 to 05f8773 Compare October 19, 2026 04:43
@potiuk potiuk mentioned this pull request Oct 19, 2026
9 of 22 tasks
The guide's "Configure it" section described private-list access and
thresholds without naming a file to configure. It now names the file
each skill reads (`committer-readiness.md`, `contributor-nomination-config.md`,
the onboarding and sentiment configs, and `privacy-llm.md` for the
private-list reads), and says `setup config` configures rather than
"personal install".

Every other family guide has a test that the family's skills resolve to
it and that it follows the general guide on the next run; this family
now has one too. The case-11 fixture that embeds the guide is
re-rendered.

Generated-by: Claude Opus 5
…702-fixup

Generated-by: Claude Opus 5

# Conflicts:
#	tools/setup-preflight/tests/test_welcome.py
#	tools/skill-evals/README.md
#	tools/skill-evals/evals/setup/README.md
#	tools/skill-evals/evals/setup/preflight-floor/fixtures/case-9-first-magpie-run/report.md

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds the contributor-growth welcome guide covering all nine skills, with the standard README block; the skills and the flow it describes check out.

I pushed two commits rather than send this round again:

  • bd56c7e — fixup. "Configure it" described private-list access and thresholds without naming a file to configure; it now names the file each skill reads (committer-readiness.md, contributor-nomination-config.md, committer-onboarding-config.md, onboarding-concierge-config.md, contributor-sentiment-config.md, and privacy-llm.md for calibration's private-list reads), and says /magpie-setup:setup config configures rather than "personal install". I also added the next-run test every other family guide has: the nine skills resolve to contributor-growth, and the guide follows the general one on the next run.
  • b48fa50 — merge of main. The mentoring, pairing, issue and PR-management guides landed first and claimed the same slots, so this fixture is now case-15-contributor-growth-first-run, the setup case counts go to 135, the test lists carry every family, and the case-9 report is re-rendered.

The PR merges automatically once CI is green. Thanks for the guide!


This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.

More on how Apache Magpie handles maintainer review:
Contributing guide.

@potiuk
potiuk enabled auto-merge (squash) October 19, 2026 20:43
@potiuk
potiuk merged commit cb92631 into apache:main Oct 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

capability:platform Framework / agent substrate skills (install, verify, doctor, override, status, setup bootstrap) family:contributor-growth contributor-growth skills family:docs Docs, MISSION.md, READMEs family:setup setup-* skills family:tools tools/* substrate:framework-dev Tool substrate: build / validate / eval the framework itself substrate:setup Tool substrate: adopter-side setup state resolved at runtime (lock parsing, floors, fingerprints)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Welcome guide: contributor-growth family

2 participants