Repository navigation
Answer 404 for theme data about a theme that doesn't exist - #283
Merged
Merged
Conversation
ThemeManager.getTheme() throws ThemeNotFoundException for an unknown id, which ThemeDataServlet reported as a 500.
mraible
marked this pull request as ready for review
November 15, 2026 21:19
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/roller-ui/authoring/themedata?theme=<id>answered 500 ("ERROR fetching theme data") for an id that doesn't exist, becauseThemeManager.getTheme()throwsThemeNotFoundExceptionand the servlet treated everyWebloggerExceptionthe same. It now answers 404 for an unknown theme and still answers 500 for other errors.ThemeDataServletTestadds a case for an unknown id.Found on a copy of raibledesigns.com while retesting #279 and #282.