Repository navigation
Name the top-level license files LICENSE and NOTICE - #285
Merged
Merged
Conversation
Apache Trusted Releases checks a source archive's root for files named exactly LICENSE and NOTICE, and blocks a candidate without them. The binary archives and the war keep LICENSE.txt and NOTICE.txt from binary-includes, which ATR accepts there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the top-level
LICENSE.txtandNOTICE.txttoLICENSEandNOTICE, and updatesassembly-release/src/main/assembly/source.xmlto match.Apache Trusted Releases blocked the 7.0.0 candidate's source archives with "No LICENSE file found" and "No NOTICE file found". Its source check (
atr/tasks/checks/license.py) looks for root files named exactlyLICENSEandNOTICE, while its binary check also accepts the.txtnames.This is deliberate on ATR's side, not a bug: in apache/tooling-trusted-releases#877, allowing
LICENSE.txtandNOTICE.txtin source packages was proposed and turned down, and only the binary check was relaxed (apache/tooling-trusted-releases@554490a06). ATR reads the release policy's requirement that a source package haveLICENSEandNOTICEat its root as those exact names, and no project setting changes that short of turning off its license file check.LICENSE.txtandNOTICE.txtfrombinary-includes/, which ATR accepts, so the install guide's description of the binary layout stays right.mvn apache-rat:checkpasses.Once this merges I'll move the
roller-7.0.0-rc1tag to the merge commit, rebuild and re-sign, and upload a new ATR revision. No vote has started yet.