SlowCompositeReaderWrapper: fix index sort and hasBlocks - #4825
Open
dsmiley wants to merge 1 commit into
Open
Conversation
…d docs) for multi-segment views Both were derived from the first segment's LeafMetaData only, which is wrong once the composite view has more than one leaf: - sort() claimed the first segment's index sort even when stacking multiple segments end-to-end, which does not preserve that sort as a whole. Consumers act on the claim (TopFieldCollector stops collecting a leaf once the search sort is a prefix of the index sort), so a search over this wrapper could silently drop hits. - hasBlocks() reported false whenever segment 0 happened to have no blocks, even if a later segment did. sort() is now null except in the trivial single-leaf case; hasBlocks() is now the OR across all leaves, since a block is never split across segments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both were derived from the first segment's LeafMetaData only, which is wrong once the composite view has more than one leaf:
sort() is now null except in the trivial single-leaf case; hasBlocks() is now the OR across all leaves, since a block is never split across segments.
_disclaimer: saw this in an experiment/hack; didn't see in the real world nor in existing tests _