Repository navigation
Update spec pin, CI validation, and sample naming - #1
Merged
Merged
Conversation
- validate-records.py: fail fast without SOURCELUME_SPEC instead of defaulting to a stale local worktree path; PR #10 is merged into spec main, so any current checkout works - ci.yml: check out apache/sourcelume-spec and validate both records in CI (previously skipped); spec main is followed unpinned until a spec release is published - README: record-type status rows now reference merged spec main and the registry follow-up PR (sourcelume-registry#15) - train.py and data/provenance-record.json: use the sample naming consistently after the training-demo rename Apache-ai: Yes Generated-by: pi (claude-sonnet-5-5) Reviewed-by: anierbeck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the sample up to date now that
TrainingProvenanceRecordis merged into the spec (apache/sourcelume-spec#10).scripts/validate-records.pyfails fast whenSOURCELUME_SPECis not set, instead of defaulting to a stale local worktree path.apache/sourcelume-specand validates both records; this step was skipped before. It follows specmainunpinned, because the spec has no published release yet.main; the registry row refers to the follow-up PR Support TrainingProvenanceRecord end to end sourcelume-registry#15.train.pyand the dataset record say "sample" instead of "training demo" after the repository rename.The registry rows stay "expected to fail" on purpose until apache/sourcelume-registry#15 is merged.
Testing
SOURCELUME_SPECthe script exits with status 2 and a hint.SOURCELUME_SPECpointing at specmain(b5ab8e7): a freshtrain.pyrun, then both records PASS.Apache-ai: Yes
Generated-by: pi (claude-sonnet-5-5)
Reviewed-by: anierbeck