fix(v1.2): raise default WebSocket payload limit to avoid dropping large result frames - #7811
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
…sult frames (#6858) ### What changes were proposed in this PR? Raises the default maximum workflow WebSocket message size from **64 KB to 1024 KB (1 MB)**, in every place the default is encoded: - `common/config/src/main/resources/application.conf` — the base config default (`web-server.max-workflow-websocket-request-payload-size-kb`) - `bin/k8s/values.yaml` — the Helm chart env default (`MAX_WORKFLOW_WEBSOCKET_REQUEST_PAYLOAD_SIZE_KB`), which overrides the base default in Kubernetes deployments - `bin/k8s/values-development.yaml` — the same env var in the development chart, which otherwise kept reproducing #6857 - `common/config/src/test/scala/.../ApplicationConfigSpec.scala` — the guard test asserting the default `WebsocketPayloadSizeTuner` applies this value to the Jetty WebSocket container's max text/binary message buffer. At the previous 64 KB default, the result/status frame pushed to the browser for a workflow with many operators or a sizable visualization payload (e.g. a Bar Chart) could exceed 65536 bytes; Jetty then drops the entire frame with `MessageTooLargeException`, so the final result/visualization never reaches the frontend even though the execution completes successfully on the backend. The overshoot is often only a couple KB, so even modest workflows can trip it. 1 MB gives ample headroom for large visualization payloads while remaining well within reasonable WebSocket frame sizes. This changes only a default value; the limit remains overridable via the `MAX_WORKFLOW_WEBSOCKET_REQUEST_PAYLOAD_SIZE_KB` environment variable. ### Any related issues, documentation, discussions? Closes #6857 ### How was this PR tested? Updated the existing guard test in `ApplicationConfigSpec` (`maxWorkflowWebsocketRequestPayloadSizeKb shouldBe 1024`), which covers the base config default. Manually verified the runtime behavior. Ran a workflow ending in a Bar Chart whose serialized result frame exceeded 64 KB: - **Before:** the visualization did not render, and the computing unit logged `MessageTooLargeException: ... too large for configured max of [65536]` at completion. - **After:** the frame is delivered and the chart renders. Also verified with `helm template` that the rendered chart env value updates to `1024` and that both charts still render cleanly. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.8 --------- (backported from commit 25b2083) Signed-off-by: ali <ali.risheh876@gmail.com> Co-authored-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
The cherry-pick conflicted and was committed with conflict markers. Resolve the conflicts on this branch, then mark this PR ready for review. Conflicting files:
|
Contributor
|
Please take a look at this backport PR, as the automatic backport failed, and mark it as ready for review once it’s ready. Thanks, @aicam |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Automated backport of #6858 to
release/v1.2.Source: 25b2083 · automation run
Any related issues, documentation, discussions?
Backport of #6858. Originally linked #6857.
How was this PR tested?
Release-branch CI runs on this branch once the conflicts are resolved and this PR is marked ready for review.
Was this PR authored or co-authored using generative AI tooling?
No.