Repository navigation
refactor(k8s): share Helm resource templates - #9452
Open
aglinxinyuan wants to merge 1 commit into
Open
aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Contributor
Automated Reviewer SuggestionsBased on the
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Share templates for nine release Services, the five observability workloads and their Services and claims, and the PostgreSQL and RustFS local volumes and claims. Service settings, workload specs, and persistence enablement and defaults stay with their callers.
The change removes 261 net lines across 17 chart files.
Any related issues, documentation, discussions?
Closes #9451.
How was this PR tested?
Ran
bash bin/k8s/tests/test_helm_values.shandhelm lint bin/k8s -f <profile.yaml>with default, NodePort, observability, and local persistence values. Compared baseline and branch renders using Helm 3.17.3 and identical chart dependencies:The fixture values make generated credentials deterministic and exercise named ports, observability enablement, and local volume binding. All 31 profiles matched across 3,880 rendered resources, including the development and AWS values. Deliberately changing the Service target port, claim access mode, or Deployment strategy produced the expected differences.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-6)