Skip to content

refactor(k8s): share Helm resource templates - #9452

Open
aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:refactor/helm-resource-templates
Open

aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:refactor/helm-resource-templates

Conversation

@aglinxinyuan

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Share templates for nine release Services, the five observability workloads and their Services and claims, and the PostgreSQL and RustFS local volumes and claims. Service settings, workload specs, and persistence enablement and defaults stay with their callers.

The change removes 261 net lines across 17 chart files.

Any related issues, documentation, discussions?

Closes #9451.

How was this PR tested?

Ran bash bin/k8s/tests/test_helm_values.sh and helm lint bin/k8s -f <profile.yaml> with default, NodePort, observability, and local persistence values. Compared baseline and branch renders using Helm 3.17.3 and identical chart dependencies:

helm template audit-defaults bin/k8s -n ns-defaults -f defaults.yaml
helm template audit-services-nodeport bin/k8s -n ns-services-nodeport -f services-NodePort.yaml
helm template audit-observability-all bin/k8s -n ns-observability-all -f observability-all.yaml
helm template audit-persistence-2 bin/k8s -n ns-persistence-2 -f persistence-2.yaml

The fixture values make generated credentials deterministic and exercise named ports, observability enablement, and local volume binding. All 31 profiles matched across 3,880 rendered resources, including the development and AWS values. Deliberately changing the Service target port, claim access mode, or Deployment strategy produced the expected differences.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Codex (GPT-6)

Copilot AI balanced review requested due to automatic review settings November 15, 2026 07:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Committers with relevant context: @parshimers
    You can request their reviews formally with /request-review @parshimers.

  • Contributors with relevant context: @Ma77Ball, @bobbai00, @zyratlo
    You can notify them by mentioning @Ma77Ball, @bobbai00, @zyratlo in a comment.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra refactor Refactor the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share repeated Helm resource templates

2 participants