Repository navigation
TIKA-4966: apply font formatting styles in docx - #3316
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Style inheritance currently implements OOXML toggle properties incorrectly, and style-class normalization has a Unicode edge case.
3 open findings
What changed in this PR
Adds DOCX character-style formatting and optional XHTML style classes.
Changes:
- Resolves bold/italic character styles and inheritance.
- Adds configurable
<span>classes with sanitized names. - Adds regression fixtures and tests.
| File | Description |
|---|---|
CHANGES.txt |
Documents the feature. |
WordExtractor.java |
Sanitizes style class names. |
OfficeParserConfig.java |
Adds the character-style class option. |
FormattingTagManager.java |
Manages style spans. |
OOXMLTikaBodyPartHandler.java |
Applies effective run styles. |
OOXMLWordAndPowerPointTextHandler.java |
Parses run style references. |
RunProperties.java |
Tracks direct/style formatting state. |
XWPFStylesShim.java |
Parses and resolves style inheritance. |
WordParserTest.java |
Tests class-name conversion. |
OOXMLDocxSAXTest.java |
Tests character-style XHTML output. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that
TIKA-XXXX)[TIKA-XXXX] Issue or pull request title)./mvnw clean install(clean testalone cannot resolve the pipes plugin zips)Generated-by: <tool>in the commit message), and consider running the pre-flight in.skills/devs/pr-review/SKILL.md— fix what it finds; don't paste its report heremainbranch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulledmainbranchtika-bom/pom.xml.We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!