Repository navigation
Conversation
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous compatibility fixtures cover selected codecs with 300-row or NULL-page samples. They do not exercise all implemented common codecs, large datasets, or Java's default BOOLEAN RLE encoding alongside other columns.
This expands the matrix to 47 implemented common type/encoding pairs, six common compression algorithms (UNCOMPRESSED, SNAPPY, GZIP, LZ4, ZSTD, LZMA2), and 32 / 4,096 / 1,000,000 rows. Each core fixture includes a separate
boolean_valuecolumn and independent, fixed-seed 10% NULL masks for the main value and BOOLEAN columns. Dedicated legacy NULL-page cases retain their structural NULL patterns. Java uses its default BOOLEAN RLE; C++ uses its implemented BOOLEAN PLAIN writer. Both readers verify actual chunk codecs, values, NULL positions, timestamps, and column alignment.max_point_number=0fixtures: 954 Java files and 918 C++ files in total.BOOLEAN RLE support (#1019) has merged into develop. The newly exposed codec defects are addressed independently in #1022 (DICTIONARY embedded NUL bytes) and #1023 (SPRINTZ extreme transitions, FIRE arithmetic, and block boundaries). This matrix PR remains draft until those fixes merge.
Baseline failures (before the independent fixes)
The complete 32-row matrix reproduces existing failures across all six compressors:
Million-row shard checks also reproduce these failures. This draft preserves the failing cases so they remain visible as merge blockers. The failing inputs are retained; fixes are provided in #1022 and #1023.
Validation
git diff --checkpassed.Independent fix validation