Repository navigation
Support provider-defined authenticated page body lengths - #1028
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #866, targeting
codex/tsfile-tde-page-aeadrather than develop.Validation
39 focused tests passed across PageCryptoContextTest, PageBodyEncoderTest, FileEncryptionHeaderTest, PageAeadReaderLifecycleTest, and EncryptionProviderRegistryTest.
Coverage includes variable-length padded framing, direct/sliced buffers, framing tampering, compression, aligned/non-aligned queries, and existing fixed-expansion lifecycle behavior.
Motivation
Allows external providers to support padded authenticated encodings such as CBC plus HMAC without making storage code infer plaintext length by subtracting a fixed overhead.