Skip to content

Fix C++ schema properties, TS_2DIFF precision, and field filters - #1040

Open
dajiaohuang wants to merge 2 commits into
apache:developfrom
dajiaohuang:w11-tsfile-issues-1017-1020
Open

dajiaohuang wants to merge 2 commits into
apache:developfrom
dajiaohuang:w11-tsfile-issues-1017-1020

Conversation

@dajiaohuang

@dajiaohuang dajiaohuang commented Oct 26, 2026 •

Copy link
Copy Markdown

Summary

  • Serialize and deserialize MeasurementSchema properties without desynchronizing the metadata stream.
  • Apply max_point_number from MeasurementSchema properties to FLOAT/DOUBLE TS_2DIFF page encoders in tree, aligned, and table writer paths.
  • Apply supplied field filters to aligned table-query rows, including invoking the predicate and excluding rejected rows.
  • Add regressions for schema property round-trip, the reported max_point_number=0 writer case, and null/accept/reject field-filter controls.

Validation

  • TsFile_Test filtered run: 28 tests passed for MeasurementSchema, FLOAT/DOUBLE TS_2DIFF codecs, and the max_point_number writer regression.
  • The writer regression failed before its fix with 1.23 instead of expected 1.0; after the fix it passes.
  • Release C++ TsFile_Test build succeeded; 26 table-reader tests passed, including FieldFilterControlsRowsAndIsInvoked. The regression confirms null filter retains one row without invocation, accept-all retains one row with one invocation, and reject-all returns zero rows with one invocation.
  • No CI, review, or merge status checked.

Fixes #1017
Fixes #1020
Fixes #1025

@dajiaohuang dajiaohuang changed the title Fix C++ schema property handling and TS_2DIFF precision Fix C++ schema properties, TS_2DIFF precision, and field filters Oct 27, 2026
@ColinLeeo ColinLeeo added bot:triaged managed by TsFile maintainer bot bot:ci-failed managed by TsFile maintainer bot and removed bot:triaged managed by TsFile maintainer bot labels Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:ci-failed managed by TsFile maintainer bot

Projects

None yet

2 participants