Repository navigation
fix(state): ignore unresolvable IRIs in IriConverterParameterProvider - #8844
Merged
Merged
Conversation
Co-authored-by: CRC <46287826+pysocrates@users.noreply.github.com>
Co-authored-by: CRC <46287826+pysocrates@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #8839, thanks @pysocrates for the report work and the first iteration.
IriConverterParameterProviderswallowed IRI conversion errors without setting a value, so the raw string reachedIriFilterand the ORM one crashed with a TypeError (500). The array branch also stopped at the first invalid IRI (break), dropping the valid ones after it, and an empty value skipped conversion.The provider now always sets resolved resources: unresolvable IRIs are skipped (logged as notice), and an unresolvable single value becomes an empty list, so the filter matches nothing. This is the same result as a well-formed IRI to a missing item, and what the ODM filter already did; its own non-object guards are removed and an empty list now yields an always-false match instead of an empty
$or.throw_not_foundis unchanged.