Skip to content

FDN-5633 Accept missing required fields that have a default - #193

Merged
gheine merged 1 commit into
mainfrom
FDN-5633-required-field-with-default
Oct 12, 2026
Merged

gheine merged 1 commit into
mainfrom
FDN-5633-required-field-with-default

Conversation

@jlogeart

@jlogeart jlogeart commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Jira: https://flowio.atlassian.net/browse/FDN-5633

Summary

validateFields rejected a required field as missing even when the spec declares a default, so the proxy returned 422 for bodies the backend deserializes fine. A required field with a default is now accepted when absent; one without a default is still rejected.

Eng-Review Summary

  • Revision: 572bb0b
  • Timestamp: 2026-10-08T14:40:00Z
  • Status: passed_with_notes
  • Issues:
    • Tag: TESTING
      Title: Real-looking fake data
      Location: JsonValidatorSpec.scala:348
      Resolution: justified
      Justification: jean@test.io is the agreed fake test value for this repo
    • Tag: TESTING
      Title: Redundant first assertion
      Location: JsonValidatorSpec.scala:347
      Resolution: justified
      Justification: the model also has a required status field with a default; asserting the error lists only emails proves status is not reported as missing, and validateValid covers the accept path

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@jlogeart
jlogeart requested a review from gheine October 8, 2026 14:49
@gheine
gheine merged commit 9c245de into main Oct 12, 2026
1 check passed
@gheine
gheine deleted the FDN-5633-required-field-with-default branch October 12, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants