Repository navigation
FDN-5633 Accept missing required fields that have a default - #193
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
gheine
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://flowio.atlassian.net/browse/FDN-5633
Summary
validateFieldsrejected a required field as missing even when the spec declares adefault, so the proxy returned 422 for bodies the backend deserializes fine. A required field with a default is now accepted when absent; one without a default is still rejected.Eng-Review Summary
Title: Real-looking fake data
Location: JsonValidatorSpec.scala:348
Resolution: justified
Justification: jean@test.io is the agreed fake test value for this repo
Title: Redundant first assertion
Location: JsonValidatorSpec.scala:347
Resolution: justified
Justification: the model also has a required status field with a default; asserting the error lists only emails proves status is not reported as missing, and validateValid covers the accept path
🤖 Generated with Claude Code