Skip to content

Store copies of values in the memory storage client #2313

New issue
New issue
Closed
#2376
Closed
Store copies of values in the memory storage client#2313
#2376
Assignees
vdusek
Labels
debtCode quality improvement or decrease of technical debt.t-toolingIssues with this label are in the ownership of the tooling team.
Milestone
2.0

Description

@vdusek
vdusek
opened on Oct 13, 2026

MemoryDatasetClient._push_item() appends the caller's dict, and MemoryKeyValueStoreClient.set_value() stores the value object itself. Mutating the object after pushing it changes the stored data, and pushing the same object twice stores two references to one object. The file system and SQL clients store independent snapshots, and they reject non-JSON values that the memory client accepts.

Store a JSON snapshot of each dataset item, and a copy of each KVS value (or serialized bytes, once #2297 lands), so the memory client behaves like the other backends.

This will be a breaking change.

JS implementation: apify/crawlee#3812, apify/crawlee#3831

✍️ Drafted by Claude Code

Activity

  1. vdusek
    added this to the 2.0 milestone on Oct 13, 2026
  2. vdusek
    added
    t-toolingIssues with this label are in the ownership of the tooling team.
    debtCode quality improvement or decrease of technical debt.
    on Oct 13, 2026

  3. janbuchar commented on Oct 15, 2026

    @janbuchar
    janbuchar
    on Oct 15, 2026
    Collaborator

    Frankly this only breaks code that relied on unspecified behavior, so breaking change is a big stretch.

  4. vdusek
    linked a pull request that will close this issuefix!: store copies of data in `MemoryStorageBackend` #2376on Nov 2, 2026
  5. vdusek
    self-assigned this
    on Nov 2, 2026
  6. vdusek
    added a commit that references this issue on Nov 2, 2026

    fix!: store copies of data in `MemoryStorageBackend` (#2376)

    52ca893

  7. vdusek commented on Nov 2, 2026

    @vdusek
    vdusek
    on Nov 2, 2026
    CollaboratorAuthor

    resolved by #2376

  8. vdusek
    closed this as completedon Nov 2, 2026
  9. vdusek
    added a commit that references this issue on Nov 5, 2026

    fix!: store copies of data in `MemoryStorageBackend` (#2376)

    45576a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

debtCode quality improvement or decrease of technical debt.t-toolingIssues with this label are in the ownership of the tooling team.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions