Repository navigation
feat(request-loaders)!: Require get_pending_count in RequestLoader implementations - #2368
Merged
Merged
Conversation
github-actions
Bot
added
the
t-tooling
vdusek
approved these changes
Oct 30, 2026
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
One minor comment, otherwise LGTM
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Mantisus
force-pushed
the
get-pending-count
branch
from
October 31, 2026 15:51
6a25d1d to
6798ce0
Compare
vdusek
changed the title
get_pending_count to RequestLoaderget_pending_count in RequestLoader implementations
vdusek
pushed a commit
that referenced
this pull request
Nov 5, 2026
…` implementations (#2368) ### Description `RequestLoader` has a new abstract `get_pending_count` method, which returns the number of requests that haven't been handled yet, like `getPendingCount` in Crawlee JS. `RequestQueue`, `SitemapRequestLoader`, `RequestManagerTandem` and `ThrottlingRequestManager` implement it. `RequestList` reads its source lazily, so it counts only the fetched requests that aren't handled yet. `RequestManagerTandem.get_total_count` no longer counts a request twice once it moves from the loader to the manager, so the crawler's status message shows the right total. The v2 upgrade guide covers the change for custom request loaders. ### Issues - Part of: #2296 *✍️ Drafted by Claude Code*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RequestLoaderhas a new abstractget_pending_countmethod, which returns the number of requests that haven't been handled yet, likegetPendingCountin Crawlee JS.RequestQueue,SitemapRequestLoader,RequestManagerTandemandThrottlingRequestManagerimplement it.RequestListreads its source lazily, so it counts only the fetched requests that aren't handled yet.RequestManagerTandem.get_total_countno longer counts a request twice once it moves from the loader to the manager, so the crawler's status message shows the right total. The v2 upgrade guide covers the change for custom request loaders.Issues
is_empty/is_finishedwithcheck_readiness()and add pacing signals toRequestManager#2296✍️ Drafted by Claude Code