Skip to content

fix: replace all hyphens in runtime SDK versions and reject non-finite coordinates - #317

Open
hoanle0126 wants to merge 1 commit into
appium:masterfrom
hoanle0126:fix/sdk-runtime-hyphen-replacement-and-location
Open

hoanle0126 wants to merge 1 commit into
appium:masterfrom
hoanle0126:fix/sdk-runtime-hyphen-replacement-and-location

Conversation

@hoanle0126

Copy link
Copy Markdown
  • In getDevices, .replace('-', '.') only replaced the first hyphen in runtime keys (turning three-part identifiers like com.apple.CoreSimulator.SimRuntime.iOS-17-5-1 into '17.5-1' instead of '17.5.1'). Use .replace(/-/g, '.') to match createDevice's .replace(/\./g, '-').
  • In setLocation, check Number.isFinite(flt) instead of isNaN(flt) so Infinity / -Infinity throw a TypeError instead of passing 'Infinity' to simctl location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant