fix(git): preserve origin segments in autocommit branches - #42120
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughBranch normalization now removes ChangesBranch name normalization
Estimated code review effort: 1 (Trivial) | ~5 minutes Mergeability Score: ⚪ Minimal · up to The change preserves branch names containing internal Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
feature/origin/mainwhen autocommit resolves the branched application.origin/prefix, matching the existing Central/Common Git branch contract.origin/segment.Context
This is the autocommit follow-up to commit
2fe167c7f901and closed PR #41793. That change corrected the Central/Common branch-listing paths, butGitAutoCommitHelperImplstill usedreplaceFirst("origin/", ""), which changesfeature/origin/mainintofeature/main. This PR scopes the fix to that missed production site and its focused unit test.Validation
git diff --checkpassed.mvn -pl appsmith-server -Dtest=GitAutoCommitHelperImplTest -DskipITs test, but this environment has nomvn; the repository build also requires Java 17 or 25 while only Java 8/10 are installed here.Summary by CodeRabbit
Bug Fixes
originas part of the branch path are preserved correctly.Tests
originsegment.