Skip to content

feat: Flutter SDK update for version 28.0.0 - #338

Closed
ChiragAgg5k wants to merge 2 commits into
mainfrom
dev
Closed

ChiragAgg5k wants to merge 2 commits into
mainfrom
dev

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the Flutter SDK for version 28.0.0.

@hansi-codes

hansi-codes Bot commented Oct 12, 2026

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

This release updates the Flutter SDK to target Appwrite 2.4 and adds passkey APIs and models. It also changes OAuth2 resource parameters, adds membership ID support, and updates SDK and dependency minimum versions.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 8
File Change
CHANGELOG.md, README.md, lib/appwrite.dart Document the 28.0.0 release and Appwrite 2.4 target.
pubspec.yaml, android/build.gradle Bump package/plugin versions, SDK minimums, and dependencies.
docs/examples/** Add passkey API examples and update OAuth2 and team examples.
lib/services/account.dart, lib/services/oauth2.dart, lib/services/teams.dart Add passkey operations and update OAuth2 resource and membership parameters.
lib/src/models/**, lib/models.dart Add passkey models and default values for response model fields.
lib/src/client_*.dart, lib/src/mqtt_*.dart, lib/src/realtime_*.dart Update SDK request headers and notification plugin API usage; reformat surrounding code.
lib/query.dart Reformat distance query builders.
test/services/account_test.dart, test/src/models/*passkey*_test.dart, test/src/models/token_secret_test.dart Add tests for passkey methods and models.
🔇 Filtered out · 1

Findings Hansi considered but did not post.

Finding Why
Default the passkey collection when it is omitted Verifier: The null dereference is possible only for a map without the required passkeys collection, but no supported response or caller producing such a map is evidenced. Account.listPasskeys deserializes the list response, its service test supplies 'passkeys': [], and PasskeyList.toMap always includes that field. Other list models (e.g. SessionList) use the same required-collection behavior; the optional total parameter explains defaulting total separately. This is speculative defensive hardening rather than a demonstrated bug. Also, the suggestion replaces lines 18–20 but includes a closing '};', leaving the existing closing '};' on line 21 and breaking Dart syntax.

Reviewed bb57500 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@ChiragAgg5k

Copy link
Copy Markdown
Member Author

Superseded: replaced by a passkeys-only minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant