Repository navigation
feat(aws): Additional plugins - #2214
Open
cvtienhoven wants to merge 1 commit into
Open
cvtienhoven wants to merge 1 commit into
cvtienhoven wants to merge 1 commit into
Conversation
|
Christiaan van Tienhoven seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
cvtienhoven
force-pushed
the
feature/additional-aws-checks
branch
from
November 17, 2026 14:12
4ecac61 to
a0dc880
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New AWS plugins plus two bug fixes.
New plugins
efsEncryptionInTransitEnabled: the EFS file system policy deniesrequests without TLS.
eventBridgeArchiveEncrypted: EventBridge archives use a KMS key ofthe desired level.
athenaWorkgroupCustomerContentEncryptionKms: Athena customercontent is encrypted with a KMS key of the account.
glueCrawlerSecurityConfiguration,glueEtlJobSecurityConfiguration,glueDevEndpointSecurityConfiguration. An optional setting requires aspecific security configuration name.
elasticacheServerlessCmkUsed,elasticacheServerlessAccessControlEnabled.securityLakeVpcFlowLogsEnabledchecks that VPCFlow Logs is a log source.
*RequiredTagsplugins (EC2/VPC resources, KMS,RDS, Redshift, S3, Lambda, DynamoDB, SNS, SQS, ACM, API Gateway,
CloudFormation, EFS, ELBv2, EventBridge, MWAA, Step Functions, and
others). They check tag keys and allowed values via the settings
required_tagsandrequired_tags_exempt_keys(S3 usess3_required_tagsands3_required_tags_exempt_keys). Both default torequiring nothing, so no organisation-specific tags are built in.
Changes to existing plugins
workgroupEncrypted: new settingathena_require_kms_key(defaultfalse). Whentrue, query results must useSSE_KMSorCSE_KMSwith a key of the account.
rdsRestorable: no longer fails instances that belong to a cluster(Multi-AZ DB cluster, Neptune, DocumentDB, not only Aurora). The cluster
is evaluated instead.
Fixes
describeFileSystemPolicyusedreliesOnService: 'EFS'. The collector looks keys up in lowercase, sothe call was never made. It is now
'efs', with a regression test(
helpers/aws/api.spec.js) that everyreliesOnServiceis lowercase.Shared code
Functions and the new Glue, Athena, ElastiCache, RDS, Redshift,
EventBridge and EC2 calls.
helpers/aws/functions.js:normalizeTags,evaluateRequiredTags,getRequiredTagsConfig,addRequiredTagsResult.Permissions
The scan role needs
securitylake:ListDataLakesandsecuritylake:ListLogSourcesfor the Security Lake plugin. Everythingelse is covered by
SecurityAudit, as checked against the managedpolicy.
Testing
exports,regionsandenginespecs pass; eslint is clean.