Skip to content

fix: preserve None labels in visualizations - #2064

Closed
Iams4kura wants to merge 1 commit into
assafelovic:mainfrom
Iams4kura:bugfix/preserve-none-mermaid-label-20260812t160259z
Closed

fix: preserve None labels in visualizations#2064
Iams4kura wants to merge 1 commit into
assafelovic:mainfrom
Iams4kura:bugfix/preserve-none-mermaid-label-20260812t160259z

Conversation

@Iams4kura

Copy link
Copy Markdown

Summary

Regression evidence

  • Before: uv run --no-project --python 3.11 --with pytest python -m pytest tests/test_visualizer_none_sentinel.py -v exited 1

  • After: uv run --no-project --python 3.11 --with pytest python -m pytest tests/test_visualizer_none_sentinel.py -v exited 0

Verification

  • uv run --no-project --python 3.11 --with pytest --with pytest-asyncio python -m pytest tests/test_none_accept_sentinels.py tests/test_visualizer_none_sentinel.py -v
  • uv run --no-project --python 3.11 python -m py_compile multi_agents/agents/visualizer.py multi_agents/agents/utils/none_sentinels.py tests/test_visualizer_none_sentinel.py tests/test_none_accept_sentinels.py
  • git diff --cached --check

Scope

  • 2 files changed, +65 / -1 lines

@assafelovic

Copy link
Copy Markdown
Owner

Landed in main via #2074 — commit 39215c5b (fix: land 15 issue-backed community fixes).

Your change was consolidated with related fixes into a single per-area commit so the whole set could be tested together; you're credited as co-author on it. It was applied to a clean tree and run against the full suite on its own before being stacked, and the merged result passes on Python 3.12, 3.13 and 3.14.

Thanks for the fix — closing as merged, and sorry it sat for a while.

Bartok9 pushed a commit to Bartok9/gpt-researcher that referenced this pull request Aug 23, 2026
Each was applied to a clean tree and run against the full suite on its
own before being stacked; the stack was then re-run together. 263 pass,
0 fail.

Backend / chat
- assafelovic#1983 remove the duplicate POST /api/reports/{id}/chat registration
  that shadowed the LLM-backed handler. Closes assafelovic#1979.
- assafelovic#1996 enable the report RAG path in ChatAgentWithMemory, which was
  gated behind 'and False', and fix the retriever kwargs. Closes assafelovic#1980.

Cost accounting (both were under-reporting cache savings)
- assafelovic#1989 price Anthropic cache_creation/cache_read tokens. Closes assafelovic#1986.
- assafelovic#2070 apply the OpenAI prompt-cache discount to cache_read tokens.
  Closes assafelovic#2065.

Retrieval / scraping quality
- assafelovic#1952 cap Searx/DuckDuckGo snippet length so real pages are still
  scraped rather than treated as prefetched content. Closes assafelovic#1846, assafelovic#1892.
- assafelovic#1944 stop ingesting anti-bot challenge pages as article content.
- assafelovic#1849 use the session for PyMuPDF downloads so the User-Agent applies;
  SEC EDGAR returns 403 to bare python-requests. Closes assafelovic#1847.
- assafelovic#1954 recover markdown-fenced LLM JSON in the source curator instead
  of silently dropping curation. Closes assafelovic#1953.

Security
- assafelovic#1818 SSRF and local-file-read guards on scraped URLs.

multi_agents
- assafelovic#2064 preserve None labels in the visualizer. Closes assafelovic#2061.
- assafelovic#1936 use the stripped output dir consistently in the publisher.

Config / providers
- assafelovic#1925 pass llm_kwargs through the deep research skill. The existing
  test double omitted llm_kwargs, which real Config always sets in
  __init__, so the fixture is corrected here rather than the fix weakened.
- assafelovic#1858 fall back to LLM_KWARGS from env when the caller passes none.
- assafelovic#1755 make OLLAMA_BASE_URL optional with a sensible default.
- assafelovic#2051 pin a jsdom override so the Next.js Docker build stops failing
  on ERR_REQUIRE_ESM. Closes assafelovic#2047.

Held back: assafelovic#1982 fails its own tests and breaks two existing ones
against this base; assafelovic#1951 conflicts with assafelovic#1944 in scraper.py and is
handled separately.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants