[pllim]

Follow up of #1154

xref astropy/astropy#20667

[pllim]

Hmm is the ubuntu wheel supposed to take this long?

[aphearin]

Sometimes it can take a couple of hours. It's a ton of cython. Although since the macos wheel built so quickly, is it possible that this is because 22.04 is so old?

[pllim]

Took 61 mins but passed. 🤷‍♀️

So, should we proceed or wait for the next cibuildwheel release? 🤔

[henryiii]

The regression is only when you set an environment variable via tool.cibuildwheel.environment that isn't supported in the host Python. So it's pretty rarely a problem, I'd think.

[aphearin]

So, should we proceed or wait for the next cibuildwheel release?

Let's wait until next week after the cibuildwheel release.

Question: will wheels.yaml need to be updated with an updated cibuildwheel version after the next release?

Either way, after the next release, I can trigger one more PR check of the build, then I'll revert wheels.yaml to only run on release, and then proceed to merge.

[pllim]

I bumped cibuildwheel to the new version released today. I'll leave this in your good hands now, @aphearin . Thanks, all!

[aphearin]

Looks like the new wheels build without issues (although now ubuntu wheels take 99 minutes), so I'll revert to building the wheels on release only and then merge. Many thanks @pllim! And thanks also to @henryiii for the consultation.

[pllim]

So... pytest happened to have a release and broke pytest-remotedata, so I will have to release pytest-remotedata first and come back to this.

In the meantime, I noticed your CI setup was outdated and updated some files, so the scope expanded.

[pllim]

@aphearin can you please re-review to make sure you are okay with the extra changes to CI setup? Thanks!

[pllim]

p.s. If you are happy with this, please do use the "squash and merge" button. 😅

[aphearin]

Many thanks @pllim!

[aphearin]

Thanks for implementing updates like this, which are opaque to me.

[henryiii]

https://learn.scientific-python.org/development/guides/gha-basic/ if you want to learn about it. :)

[aphearin]

Thanks for implementing updates like this, which are opaque to me.

[pllim]

Actually I see that you don't really use devdeps in your tox env but when you decide to, hopefully it would Just Work. ™️ 😸