Skip to content

Crowd: fix attribute store verb and LDAP stats path, add missing endpoints and paging params - #1656

Closed
devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
devin/1786998612-crowd-7-2-coverage
Closed

Crowd: fix attribute store verb and LDAP stats path, add missing endpoints and paging params#1656
devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
devin/1786998612-crowd-7-2-coverage

Conversation

@devin-ai-integration

Copy link
Copy Markdown

Summary

Audited atlassian/crowd.py against Crowd's published REST contract (WADL, usermanagement/1 + admin/1.0 + appmanagement/1) and fixed endpoints that could never have worked, then filled in the remaining gaps.

Bug fixes (these previously hit the wrong verb/path and would 405/404):

-user_store_attributes  -> PUT  usermanagement/user/attribute
+user_store_attributes  -> POST usermanagement/user/attribute   # storeUserAttributes
-group_store_attributes -> PUT  usermanagement/group/attribute
+group_store_attributes -> POST usermanagement/group/attribute  # storeGroupAttributes
-get_dynamic_ldap_pool_statistics -> admin/1.0/dynamic-ldap-pool-statistics
+get_dynamic_ldap_pool_statistics -> admin/1.0/spring-ldap-pool-statistics  # getDynamicLdapPoolsStatistics

New endpoints that had no wrapper: user_by_openid (GET usermanagement/user/id?openid=), get_email_scan_result / trigger_email_scan (admin/1.0/application/{id}/emailscan), dismiss_message, and the database encryption group (get_encryption_settings, set_default_encryptor, change_encryption_key, disable_encryption).

Documented query parameters that the wrappers silently dropped, all optional so existing calls are unchanged:

user(username=None, key=None)                       # lookup by user key
user_groups(username, kind, groupname, start_index, max_results)
group_members(group, kind, username, start_index, max_results)
nested_group_members(groupname, username, start_index, max_results)
nested_user_groups(username, groupname, start_index, max_results)

Docs gained the previously undocumented user_attributes, group_attributes, get_access_based_synchronization, update_access_based_synchronization, parse_saml_metadata_file plus everything above; tests cover each fix and new method.

Note: the Crowd 7.2 postman/swagger files mentioned in the request didn't arrive with the session, so this is based on the official WADL contract — happy to extend once they're uploaded.

Link to Devin session: https://app.devin.ai/sessions/cc77925cd4db4757bfc7ebb068845066
Requested by: @gonchik

…endpoints and paging params

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@gonchik gonchik self-assigned this Aug 17, 2026
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.60%. Comparing base (b6b3f62) to head (c7dff39).

Files with missing lines Patch % Lines
atlassian/crowd.py 92.50% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1656      +/-   ##
==========================================
+ Coverage   60.48%   60.60%   +0.12%     
==========================================
  Files         105      105              
  Lines       18006    18033      +27     
  Branches     1842     1846       +4     
==========================================
+ Hits        10891    10929      +38     
+ Misses       6655     6641      -14     
- Partials      460      463       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gonchik gonchik closed this Aug 17, 2026
@gonchik
gonchik deleted the devin/1786998612-crowd-7-2-coverage branch August 17, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant