Crowd: fix attribute store verb and LDAP stats path, add missing endpoints and paging params - #1656
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
Conversation
…endpoints and paging params Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1656 +/- ##
==========================================
+ Coverage 60.48% 60.60% +0.12%
==========================================
Files 105 105
Lines 18006 18033 +27
Branches 1842 1846 +4
==========================================
+ Hits 10891 10929 +38
+ Misses 6655 6641 -14
- Partials 460 463 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audited
atlassian/crowd.pyagainst Crowd's published REST contract (WADL,usermanagement/1+admin/1.0+appmanagement/1) and fixed endpoints that could never have worked, then filled in the remaining gaps.Bug fixes (these previously hit the wrong verb/path and would 405/404):
New endpoints that had no wrapper:
user_by_openid(GET usermanagement/user/id?openid=),get_email_scan_result/trigger_email_scan(admin/1.0/application/{id}/emailscan),dismiss_message, and the database encryption group (get_encryption_settings,set_default_encryptor,change_encryption_key,disable_encryption).Documented query parameters that the wrappers silently dropped, all optional so existing calls are unchanged:
Docs gained the previously undocumented
user_attributes,group_attributes,get_access_based_synchronization,update_access_based_synchronization,parse_saml_metadata_fileplus everything above; tests cover each fix and new method.Note: the Crowd 7.2 postman/swagger files mentioned in the request didn't arrive with the session, so this is based on the official WADL contract — happy to extend once they're uploaded.
Link to Devin session: https://app.devin.ai/sessions/cc77925cd4db4757bfc7ebb068845066
Requested by: @gonchik