Skip to content

[Confluence] ConfluenceCloud: get_page_by_id(get_body=False) no longer sends body-format=none #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
star7js wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Confluence] ConfluenceCloud: get_page_by_id(get_body=False) no longer sends body-format=none #1719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion atlassian/confluence/cloud/cloud.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,9 @@ def get_page_by_id(
params["body-format"] = body_format

if not get_body:
params["body-format"] = "none"
# "none" is not a valid body-format and Confluence answers 400.
# Leaving body-format out returns the page without a body.
params.pop("body-format", None)

if expand:
params["expand"] = ",".join(expand)
Expand Down
10 changes: 9 additions & 1 deletion tests/test_confluence_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,17 @@ def test_get_page_by_id_without_body(self, mock_get):
response = self.confluence_v2.get_page_by_id("123", get_body=False)

# Assertions
mock_get.assert_called_once_with("api/v2/pages/123", params={"body-format": "none"})
mock_get.assert_called_once_with("api/v2/pages/123", params={})
self.assertEqual(response, mock_response)

@patch("atlassian.confluence.cloud.ConfluenceCloud.get")
def test_get_page_by_id_without_body_ignores_body_format(self, mock_get):
mock_get.return_value = {"id": "123", "title": "Test Page"}

self.confluence_v2.get_page_by_id("123", body_format="storage", get_body=False)

mock_get.assert_called_once_with("api/v2/pages/123", params={})

@patch("atlassian.confluence.cloud.ConfluenceCloud.get")
def test_get_page_versions(self, mock_get):
mock_response = {"results": [{"number": 2}]}
Expand Down
Loading