Skip to content

fix: reject dot-segment path parameters #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ankita10119 wants to merge 1 commit into
base: v5
Choose a base branch
from
+328 −273
Draft

fix: reject dot-segment path parameters #1441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/management/api/resources/actions/client/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ export class ActionsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/actions/${core.url.encodePathParam(id)}`,
`actions/actions/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "GET",
headers: _headers,
Expand Down Expand Up @@ -366,7 +366,7 @@ export class ActionsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/actions/${core.url.encodePathParam(id)}`,
`actions/actions/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "DELETE",
headers: _headers,
Expand Down Expand Up @@ -449,7 +449,7 @@ export class ActionsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/actions/${core.url.encodePathParam(id)}`,
`actions/actions/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "PATCH",
headers: _headers,
Expand Down Expand Up @@ -530,7 +530,7 @@ export class ActionsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/actions/${core.url.encodePathParam(id)}/deploy`,
`actions/actions/${core.url.encodePathParam(id, errors.ManagementError)}/deploy`,
),
method: "POST",
headers: _headers,
Expand Down Expand Up @@ -613,7 +613,7 @@ export class ActionsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/actions/${core.url.encodePathParam(id)}/test`,
`actions/actions/${core.url.encodePathParam(id, errors.ManagementError)}/test`,
),
method: "POST",
headers: _headers,
Expand Down
2 changes: 1 addition & 1 deletion src/management/api/resources/actions/resources/executions/client/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export class ExecutionsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/executions/${core.url.encodePathParam(id)}`,
`actions/executions/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "GET",
headers: _headers,
Expand Down
10 changes: 5 additions & 5 deletions src/management/api/resources/actions/resources/modules/client/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ export class ModulesClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/modules/${core.url.encodePathParam(id)}`,
`actions/modules/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "GET",
headers: _headers,
Expand Down Expand Up @@ -333,7 +333,7 @@ export class ModulesClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/modules/${core.url.encodePathParam(id)}`,
`actions/modules/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "DELETE",
headers: _headers,
Expand Down Expand Up @@ -418,7 +418,7 @@ export class ModulesClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/modules/${core.url.encodePathParam(id)}`,
`actions/modules/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "PATCH",
headers: _headers,
Expand Down Expand Up @@ -509,7 +509,7 @@ export class ModulesClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/modules/${core.url.encodePathParam(id)}/actions`,
`actions/modules/${core.url.encodePathParam(id, errors.ManagementError)}/actions`,
),
method: "GET",
headers: _headers,
Expand Down Expand Up @@ -624,7 +624,7 @@ export class ModulesClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/modules/${core.url.encodePathParam(id)}/rollback`,
`actions/modules/${core.url.encodePathParam(id, errors.ManagementError)}/rollback`,
),
method: "POST",
headers: _headers,
Expand Down
6 changes: 3 additions & 3 deletions src/management/api/resources/actions/resources/modules/resources/versions/client/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export class VersionsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/modules/${core.url.encodePathParam(id)}/versions`,
`actions/modules/${core.url.encodePathParam(id, errors.ManagementError)}/versions`,
),
method: "GET",
headers: _headers,
Expand Down Expand Up @@ -179,7 +179,7 @@ export class VersionsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/modules/${core.url.encodePathParam(id)}/versions`,
`actions/modules/${core.url.encodePathParam(id, errors.ManagementError)}/versions`,
),
method: "POST",
headers: _headers,
Expand Down Expand Up @@ -271,7 +271,7 @@ export class VersionsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/modules/${core.url.encodePathParam(id)}/versions/${core.url.encodePathParam(versionId)}`,
`actions/modules/${core.url.encodePathParam(id, errors.ManagementError)}/versions/${core.url.encodePathParam(versionId, errors.ManagementError)}`,
),
method: "GET",
headers: _headers,
Expand Down
4 changes: 2 additions & 2 deletions src/management/api/resources/actions/resources/triggers/resources/bindings/client/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export class BindingsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/triggers/${core.url.encodePathParam(triggerId)}/bindings`,
`actions/triggers/${core.url.encodePathParam(triggerId, errors.ManagementError)}/bindings`,
),
method: "GET",
headers: _headers,
Expand Down Expand Up @@ -177,7 +177,7 @@ export class BindingsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/triggers/${core.url.encodePathParam(triggerId)}/bindings`,
`actions/triggers/${core.url.encodePathParam(triggerId, errors.ManagementError)}/bindings`,
),
method: "PATCH",
headers: _headers,
Expand Down
6 changes: 3 additions & 3 deletions src/management/api/resources/actions/resources/versions/client/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export class VersionsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/actions/${core.url.encodePathParam(actionId)}/versions`,
`actions/actions/${core.url.encodePathParam(actionId, errors.ManagementError)}/versions`,
),
method: "GET",
headers: _headers,
Expand Down Expand Up @@ -175,7 +175,7 @@ export class VersionsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/actions/${core.url.encodePathParam(actionId)}/versions/${core.url.encodePathParam(id)}`,
`actions/actions/${core.url.encodePathParam(actionId, errors.ManagementError)}/versions/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "GET",
headers: _headers,
Expand Down Expand Up @@ -264,7 +264,7 @@ export class VersionsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`actions/actions/${core.url.encodePathParam(actionId)}/versions/${core.url.encodePathParam(id)}/deploy`,
`actions/actions/${core.url.encodePathParam(actionId, errors.ManagementError)}/versions/${core.url.encodePathParam(id, errors.ManagementError)}/deploy`,
),
method: "POST",
headers: _headers,
Expand Down
4 changes: 2 additions & 2 deletions src/management/api/resources/anomaly/resources/blocks/client/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export class BlocksClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`anomaly/blocks/ips/${core.url.encodePathParam(id)}`,
`anomaly/blocks/ips/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "GET",
headers: _headers,
Expand Down Expand Up @@ -134,7 +134,7 @@ export class BlocksClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`anomaly/blocks/ips/${core.url.encodePathParam(id)}`,
`anomaly/blocks/ips/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "DELETE",
headers: _headers,
Expand Down
8 changes: 4 additions & 4 deletions src/management/api/resources/branding/resources/phone/resources/providers/client/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ export class ProvidersClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`branding/phone/providers/${core.url.encodePathParam(id)}`,
`branding/phone/providers/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "GET",
headers: _headers,
Expand Down Expand Up @@ -316,7 +316,7 @@ export class ProvidersClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`branding/phone/providers/${core.url.encodePathParam(id)}`,
`branding/phone/providers/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "DELETE",
headers: _headers,
Expand Down Expand Up @@ -400,7 +400,7 @@ export class ProvidersClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`branding/phone/providers/${core.url.encodePathParam(id)}`,
`branding/phone/providers/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "PATCH",
headers: _headers,
Expand Down Expand Up @@ -493,7 +493,7 @@ export class ProvidersClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`branding/phone/providers/${core.url.encodePathParam(id)}/try`,
`branding/phone/providers/${core.url.encodePathParam(id, errors.ManagementError)}/try`,
),
method: "POST",
headers: _headers,
Expand Down
10 changes: 5 additions & 5 deletions src/management/api/resources/branding/resources/phone/resources/templates/client/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ export class TemplatesClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`branding/phone/templates/${core.url.encodePathParam(id)}`,
`branding/phone/templates/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "GET",
headers: _headers,
Expand Down Expand Up @@ -303,7 +303,7 @@ export class TemplatesClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`branding/phone/templates/${core.url.encodePathParam(id)}`,
`branding/phone/templates/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "DELETE",
headers: _headers,
Expand Down Expand Up @@ -385,7 +385,7 @@ export class TemplatesClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`branding/phone/templates/${core.url.encodePathParam(id)}`,
`branding/phone/templates/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "PATCH",
headers: _headers,
Expand Down Expand Up @@ -474,7 +474,7 @@ export class TemplatesClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`branding/phone/templates/${core.url.encodePathParam(id)}/reset`,
`branding/phone/templates/${core.url.encodePathParam(id, errors.ManagementError)}/reset`,
),
method: "PATCH",
headers: _headers,
Expand Down Expand Up @@ -562,7 +562,7 @@ export class TemplatesClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`branding/phone/templates/${core.url.encodePathParam(id)}/try`,
`branding/phone/templates/${core.url.encodePathParam(id, errors.ManagementError)}/try`,
),
method: "POST",
headers: _headers,
Expand Down
6 changes: 3 additions & 3 deletions src/management/api/resources/branding/resources/themes/client/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ export class ThemesClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`branding/themes/${core.url.encodePathParam(themeId)}`,
`branding/themes/${core.url.encodePathParam(themeId, errors.ManagementError)}`,
),
method: "GET",
headers: _headers,
Expand Down Expand Up @@ -357,7 +357,7 @@ export class ThemesClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`branding/themes/${core.url.encodePathParam(themeId)}`,
`branding/themes/${core.url.encodePathParam(themeId, errors.ManagementError)}`,
),
method: "DELETE",
headers: _headers,
Expand Down Expand Up @@ -505,7 +505,7 @@ export class ThemesClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`branding/themes/${core.url.encodePathParam(themeId)}`,
`branding/themes/${core.url.encodePathParam(themeId, errors.ManagementError)}`,
),
method: "PATCH",
headers: _headers,
Expand Down
6 changes: 3 additions & 3 deletions src/management/api/resources/clientGrants/client/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ export class ClientGrantsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`client-grants/${core.url.encodePathParam(id)}`,
`client-grants/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "GET",
headers: _headers,
Expand Down Expand Up @@ -344,7 +344,7 @@ export class ClientGrantsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`client-grants/${core.url.encodePathParam(id)}`,
`client-grants/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "DELETE",
headers: _headers,
Expand Down Expand Up @@ -421,7 +421,7 @@ export class ClientGrantsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`client-grants/${core.url.encodePathParam(id)}`,
`client-grants/${core.url.encodePathParam(id, errors.ManagementError)}`,
),
method: "PATCH",
headers: _headers,
Expand Down
2 changes: 1 addition & 1 deletion src/management/api/resources/clientGrants/resources/organizations/client/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export class OrganizationsClient {
(await core.Supplier.get(this._options.baseUrl)) ??
(await core.Supplier.get(this._options.environment)) ??
environments.ManagementEnvironment.Default,
`client-grants/${core.url.encodePathParam(id)}/organizations`,
`client-grants/${core.url.encodePathParam(id, errors.ManagementError)}/organizations`,
),
method: "GET",
headers: _headers,
Expand Down
Loading
Loading