Repository navigation
fix(parser): accept Cognito pre token generation V2 and V3 events - #8863
Open
Manishram-ai wants to merge 1 commit into
Open
Manishram-ai wants to merge 1 commit into
Manishram-ai wants to merge 1 commit into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number:
closes #8861
Summary
Changes
CognitoPreTokenGenerationRequestModelV2AndV3.scopesis nowlist[str] | None. Cognito sends scopes as a list of strings, so the olddicttype rejected every V2 and V3 event that had them.CognitoPreTokenGenerationTriggerModelV2AndV3now hastriggerSource: str, the same asCognitoPreTokenGenerationTriggerModelV1and the other Cognito trigger models.cognitoPreTokenV2GenerationEvent.json, already intests/events, is now in the parse test list, and a new test checksscopesandtriggerSource.User experience
Before, parsing a V2 or V3 pre token generation event failed with
Input should be a valid dictionaryforrequest.scopes, so the model couldn't be used with events from Cognito. Now they parse,parsed.request.scopesis the list Cognito sent, andparsed.triggerSourcesays which flow invoked the function, for exampleTokenGeneration_RefreshTokens.About ADR 0006, the model now rejects a dict
scopesand an event withouttriggerSource, which it accepted before. Cognito sends neither, so this only changes things for hand-written events. I treated it as a fix to match the AWS contract, like #8793 did for the VPC Lattice V2 list values. If you'd rather keep accepting those inputs with aPowertoolsUserWarninguntil the next major, I'm happy to change it.Verification
developwithInput should be a valid dictionaryand pass with this change.tests/unit/parserandtests/functional/parser: 274 passed on Python 3.10, 3.12 and 3.14 (272 ondevelop).tests/unit: 703 passed, 1 skipped.tests/performanceand the Cognito data class tests pass.ruff format --check,ruff checkandmypy aws_lambda_powertools examplesare clean.tests/events.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.