Repository navigation
fix(parser): keep query strings in APIGatewayWebSocketConnectEventModel - #8864
Open
Manishram-ai wants to merge 1 commit into
Open
Manishram-ai wants to merge 1 commit into
Manishram-ai wants to merge 1 commit into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number:
closes #8862
Summary
Changes
APIGatewayWebSocketConnectEventModelnow hasquery_string_parametersandmulti_value_query_string_parameters, read fromqueryStringParametersandmultiValueQueryStringParameters. Both default toNone, so connections without a query string parse the same as before.apiGatewayWebSocketApiConnect.jsonand checks both fields, and the other removes them from the event and checks they come back asNone.APIGatewayWebSocketDisconnectEventModelalone. Its test event has query strings, but I couldn't find anything showing$disconnectevents carry them.User experience
Before, the query string of a
$connectrequest, such as a token or a user ID, was dropped, so a handler using the model couldn't read it. Nowparsed.query_string_parametersreturns{'userId': 'user123', 'token': 'abc.def.ghi'}for the repo's connect event. Events without a query string parse as before, and no existing field changes.Verification
develop, where the model has noquery_string_parameters, and pass with this change.tests/unit/parserandtests/functional/parser: 274 passed on Python 3.10, 3.12 and 3.14 (272 ondevelop).tests/unit: 703 passed, 1 skipped.tests/performancepasses.ruff format --check,ruff checkandmypy aws_lambda_powertools examplesare clean.$connectexample in the API Gateway docs, the connect event intests/events, and the WebSocket authorizer event intests/events, which has the same two fields.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.